You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ja...@apache.org on 2014/03/23 07:31:53 UTC
svn commit: r1580455 -
/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/test/ProductionRunTests.xml
Author: jacopoc
Date: Sun Mar 23 06:31:53 2014
New Revision: 1580455
URL: http://svn.apache.org/r1580455
Log:
Fixed a bug in a test case that was causing a test failure when a Daylight Saving Time change was scheduled within a week: the test was trying to accept a +/1 hour difference but since the unit of measure of time was milliseconds then it had to be +/-60*60*1000=+/-3600000
Thanks to Christian Geisert for the fix.
Modified:
ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/test/ProductionRunTests.xml
Modified: ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/test/ProductionRunTests.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/test/ProductionRunTests.xml?rev=1580455&r1=1580454&r2=1580455&view=diff
==============================================================================
--- ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/test/ProductionRunTests.xml (original)
+++ ofbiz/trunk/applications/manufacturing/script/org/ofbiz/manufacturing/test/ProductionRunTests.xml Sun Mar 23 06:31:53 2014
@@ -273,9 +273,9 @@ under the License.
<if-compare-field field="productionRunTask.estimatedStartDate" operator="equals" to-field="productionRunNewStartDate" type="Timestamp"/>
<or>
<if-compare field="taskTimeDifference" operator="equals" value="0.0" type="Double"/>
- <!-- a difference of +1 or -1 is accepted because it could be caused by DST change happening in one of the two time periods -->
- <if-compare field="taskTimeDifference" operator="equals" value="1.0" type="Double"/>
- <if-compare field="taskTimeDifference" operator="equals" value="-1.0" type="Double"/>
+ <!-- a difference of +1 or -1 hour is accepted because it could be caused by DST change happening in one of the two time periods -->
+ <if-compare field="taskTimeDifference" operator="equals" value="3600000.0" type="Double"/>
+ <if-compare field="taskTimeDifference" operator="equals" value="-3600000.0" type="Double"/>
</or>
</assert>
<check-errors/>