You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/24 12:42:32 UTC
[GitHub] [pulsar] mantuliu opened a new pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
mantuliu opened a new pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078
Fixes #10975
### Motivation
*conf/stanalone.conf is missing the configuration of brokerDeleteInactivePartitionedTopicMetadataEnabled*
### Modifications
*Add brokerDeleteInactivePartitionedTopicMetadataEnabled in conf/stanalone.conf*
### Verifying this change
- [X] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078#issuecomment-882530603
@mantuliu Can you process the suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mantuliu closed pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
mantuliu closed pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078#issuecomment-882530603
@mantuliu Can you process the suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mantuliu closed pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
mantuliu closed pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mantuliu closed pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
mantuliu closed pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078#issuecomment-882530603
@mantuliu Can you process the suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11078:
URL: https://github.com/apache/pulsar/pull/11078#discussion_r658413752
##########
File path: conf/standalone.conf
##########
@@ -105,6 +105,11 @@ brokerDeleteInactiveTopicsEnabled=true
# How often to check for inactive topics
brokerDeleteInactiveTopicsFrequencySeconds=60
+# Metadata of inactive partitioned topic will not be cleaned up automatically by default.
+# Note: If `allowAutoTopicCreation` and this option are enabled at the same time,
+# it may appear that a partitioned topic has just been deleted but is automatically created as a non-partitioned topic.
+brokerDeleteInactivePartitionedTopicMetadataEnabled=false
Review comment:
```suggestion
# By default, metadata of inactive partitioned topics is not cleaned up automatically.
# Note: If `allowAutoTopicCreation` and `brokerDeleteInactivePartitionedTopicMetadataEnabled` are enabled at the same time,
# a partitioned topic which has been deleted might be automatically created as a non-partitioned topic.
brokerDeleteInactivePartitionedTopicMetadataEnabled=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org