[GitHub] [ignite] AMashenkov commented on a change in pull request #7936: IGNITE-13154 Introduce the ability for a user to manage binary types

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #7936:
URL: https://github.com/apache/ignite/pull/7936#discussion_r442743689



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/commandline/CommandArgIterator.java
##########
@@ -97,19 +97,52 @@ public String peekNextArg() {
         return peekedArg;
     }
 
+    /**
+     * @return Numeric value.
+     */
+    public long nextPositiveLongArg(String argName) {
+        long val = nextLongArg(argName);
+
+        if (val < 0)

Review comment:
       Actually, val is "non-negative" rather "positive"
   Let's rename methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org