You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/16 18:43:46 UTC
[GitHub] [spark] srowen commented on a change in pull request #30810: [WIP][ML] Add a vectorized BLAS implementation
srowen commented on a change in pull request #30810:
URL: https://github.com/apache/spark/pull/30810#discussion_r544536426
##########
File path: mllib-local/pom.xml
##########
@@ -56,6 +56,11 @@
<groupId>org.apache.spark</groupId>
<artifactId>spark-tags_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-core_${scala.binary.version}</artifactId>
Review comment:
I know, but we won't be able to allow that dependency. You can 'inline' Utils.classForName, and eventually we won't need the benchmark (or maybe the test-scope dependency is OK). For experiments now it's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org