You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Francis Chuang (JIRA)" <ji...@apache.org> on 2018/06/27 01:49:00 UTC
[jira] [Updated] (CALCITE-2385) Cannot build if we update the
AVATICA_VERSION in the dockerfile during a dry-run release
[ https://issues.apache.org/jira/browse/CALCITE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Chuang updated CALCITE-2385:
------------------------------------
Description:
This happens when building a dry-run release per the instructions here: [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there being modified files in the working tree.
If we do not patch the docker file, maven fails because it expects AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
A solution would be to exclude the docker file from being checked for modifications in pom.xml. Is this a reasonable approach?
CC [~elserj]
was:
This happens when building a dry-run release per the instructions here: [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there being modified files in the working tree.
If we do not patch the docker file, maven fails because it expects AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
A solution would be to exclude the docker file from being checked for modifications in pom.xml. Is this a reasonable approach?
> Cannot build if we update the AVATICA_VERSION in the dockerfile during a dry-run release
> ----------------------------------------------------------------------------------------
>
> Key: CALCITE-2385
> URL: https://issues.apache.org/jira/browse/CALCITE-2385
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Francis Chuang
> Priority: Major
>
> This happens when building a dry-run release per the instructions here: [https://calcite.apache.org/avatica/docs/howto.html#making-a-release-for-calcite-committers]
> If we patch the dockerfile to include `-SNAPSHOT`, maven fails due to there being modified files in the working tree.
> If we do not patch the docker file, maven fails because it expects AVATICA_VERSION to be $VERSION-SNAPSHOT rather than $VERSION.
> A solution would be to exclude the docker file from being checked for modifications in pom.xml. Is this a reasonable approach?
>
> CC [~elserj]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)