You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/06/13 17:41:51 UTC
[jira] [Commented] (CASSANDRA-2045) Simplify HH to decrease read
load when nodes come back
[ https://issues.apache.org/jira/browse/CASSANDRA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048603#comment-13048603 ]
Jonathan Ellis commented on CASSANDRA-2045:
-------------------------------------------
Looks pretty good to me. I'd only add that you should use RowMutation.getSerializedBuffer (which caches, so you don't redo the serialize unnecessarily for the commitlog as well), instead of manually using the serializer. And of course the obvious about following the C* code style (http://wiki.apache.org/cassandra/CodeStyle).
The more I think about it the less I think it's worth keeping the old-style hinting around. The cleanup caveat (cleanup will throw out rows that don't belong to this replica, even if they have hints) is a pretty big one, even if it's fairly obscure (rows that don't belong will only be hinted for CL.ANY when all other replicas are down).
> Simplify HH to decrease read load when nodes come back
> ------------------------------------------------------
>
> Key: CASSANDRA-2045
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2045
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Chris Goffinet
> Assignee: Nicholas Telford
> Fix For: 1.0
>
> Attachments: CASSANDRA-2045-simplify-hinted-handoff-001.diff
>
>
> Currently when HH is enabled, hints are stored, and when a node comes back, we begin sending that node data. We do a lookup on the local node for the row to send. To help reduce read load (if a node is offline for long period of time) we should store the data we want forward the node locally instead. We wouldn't have to do any lookups, just take byte[] and send to the destination.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira