Found a couple of bugs in ecs 1.4.1

["James C. McMaster (Jim)" <mc...@tatanka.stortek.com>]

I cannot get into cvs through our firewall, and do not know how to submit a 
patch.  I did find a couple of bugs, though, and wanted to let you know about 
them.  I tried sending them to the owners at jon@clearlink.com and 
snagy@servletapi.com, but both messages were returned as undeliverable.

First, in org.apache.ecs.ElementAttributes.java:

addAttribute has a flavor that accepts an int, Integer or Object as an 
attribute value.  If you use anything but a String, though, you get a 
ClassCastException in createStartTag.  On line 352, in the "else" branch 
where getAttributeFilterState() is false, the code is:

value = (String) getElementHashEntry().get(attr);

it should be:

value = getElementHashEntry().get(attr).toString();

Second, in org.apache.ecs.html.Script:

I defined a Script element as follows:

new Script().setSrc("js/Generic.js").setType("text/javascript")
.setLanguage("JavaScript")

When this was output, I got:

<script type="text/javascript" src="js/Generic.js" language="JavaScript">
    <!--

    // -->
</script>

Since the script has a "body" defined inline, the src attribute is ignored.

The problem is, createStartTag() and createEndTag() generate the comments 
whether or not there is a body to surround.  The fix is to surround the three 
"out.append(..." lines in each method with:

if (!(hasAttribute("src"))) {
    .
    .
    .
}

I hope these will be seen by the right people.
-- 
Jim McMaster
mailto:mcmasjc@tatanka.stortek.com





---------------------------------------------------------------------
To unsubscribe, e-mail: ecs-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: ecs-user-help@jakarta.apache.org

Re: Found a couple of bugs in ecs 1.4.1

[robert burrell donkin <ro...@blueyonder.co.uk>]

On Thursday, April 3, 2003, at 12:24 AM, James C. McMaster (Jim) wrote:

> I cannot get into cvs through our firewall, and do not know how to submit 
> a
> patch.  I did find a couple of bugs, though, and wanted to let you know 
> about
> them.  I tried sending them to the owners at jon@clearlink.com and
> snagy@servletapi.com, but both messages were returned as undeliverable.

both jon and stephan have new email address now. in any case, the mailing 
list is the right way to raise these kinds of issues.

<snip>

> I hope these will be seen by the right people.

i'll take a look at these soon.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: ecs-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: ecs-user-help@jakarta.apache.org