Re: [PR] IGNITE-25720 Fix failed tests SnapshotCompressionBasicTest [ignite]

["shishkovilja (via GitHub)" <gi...@apache.org>]

shishkovilja commented on code in PR #12160:
URL: https://github.com/apache/ignite/pull/12160#discussion_r2332772077


##########
modules/compress/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCompressionBasicTest.java:
##########
@@ -223,6 +226,8 @@ public void testRestoreFail_OnGridWithoutCompression() throws Exception {
                 "from snapshot '" + snpName + "' are compressed while disk page compression is disabled. To check " +
                     "these groups please start Ignite with ignite-compress"
             );
+
+            waitDestruction();

Review Comment:
   What do we wait here? Is there even one cache destroy here?



##########
modules/compress/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCompressionBasicTest.java:
##########
@@ -498,4 +505,15 @@ static class Value {
             return Objects.hash(name);
         }
     }
+
+    /** */
+    private void waitDestruction() {
+        try {
+            // Wait for caches to be completely destroyed
+            Thread.sleep(1000L);

Review Comment:
   It ensures nothing. Any GC-pause or delay and test will become flaky again.



##########
modules/compress/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCompressionBasicTest.java:
##########
@@ -203,6 +204,8 @@ private void testRestoreFullSnapshot(int gridCnt) throws Exception {
             finally {
                 locEvts.clear();
             }
+
+            waitDestruction();

Review Comment:
   Let's move it to before test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org