You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2025/05/11 18:31:36 UTC
[PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
jonkeane opened a new pull request, #46397:
URL: https://github.com/apache/arrow/pull/46397
### Rationale for this change
Fix gcc-UBSAN CI job to be correctly running, then fix the UBSAN error.
### What changes are included in this PR?
* Generalize our sanitizer jobs and use rhub's containers for this. wch/r-debug looks like it's out of date (hence why we didn't catch this), and it's easier to use a matrix of images with rhubarb anyway.
* TODO: the actual fix
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2874917294
@github-actions crossbow submit test-r-linux-sanitizers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2870722663
`Python / AMD64 Conda Python 3.10 Without Pandas` is failing on main right now too, so not the changes in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #46397:
URL: https://github.com/apache/arrow/pull/46397#discussion_r2083762704
##########
cpp/src/arrow/csv/parser.cc:
##########
@@ -144,7 +144,11 @@ class ValueDescWriter {
protected:
ValueDescWriter(MemoryPool* pool, int64_t values_capacity)
- : values_size_(0), values_capacity_(values_capacity), status_(Status::OK()) {
+ : values_size_(0),
+ values_capacity_(values_capacity),
+ quoted_(false),
+ saved_values_size_(0),
+ status_(Status::OK()) {
Review Comment:
`quoted_(false)` and `saved_values_size_(0)` are the only additions here (the rest is whitespace)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2870441719
Revision: cbc67be40f14966160d3679c43618a8f354ba12b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-faacd3047b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-faacd3047b)
|Task|Status|
|----|------|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/14961612620/job/42024421318)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2870444389
@github-actions crossbow submit test-r-linux-sanitizers
And this one intializes the quoted variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2870446813
Revision: f261c5623057f416068a02c7b8662298f67e1de3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b0ff1d4e40](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b0ff1d4e40)
|Task|Status|
|----|------|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/14961660157/job/42024536499)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2870041835
:warning: GitHub issue #46394 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #46397:
URL: https://github.com/apache/arrow/pull/46397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2870439475
@github-actions crossbow submit test-r-linux-sanitizers
This should fail with the new rhub/gcc-asan job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46397:
URL: https://github.com/apache/arrow/pull/46397#discussion_r2085733144
##########
dev/tasks/tasks.yml:
##########
@@ -1081,30 +1081,17 @@ tasks:
r_tag: latest
flags: "-e LIBARROW_MINIMAL=TRUE"
- test-r-linux-sanitizer:
+ test-r-linux-sanitizers:
ci: github
- template: docker-tests/github.linux.yml
- params:
- env:
- R_PRUNE_DEPS: TRUE
- image: ubuntu-r-sanitizer
- timeout: 120
-
- test-r-clang-asan:
- ci: github
- template: docker-tests/github.linux.yml
+ template: r/github.linux.sanitizers.yml
params:
env:
R_PRUNE_DEPS: TRUE
- image: r-clang-asan
-
- test-r-clang-ubsan:
- ci: github
- template: docker-tests/github.linux.yml
- params:
- env:
- R_PRUNE_DEPS: TRUE
- image: r-clang-ubsan
+ R_ORG: "rhub"
+ R_IMAGE: "{{ '${{ matrix.config.r_image }}' }}"
+ R_TAG: "latest"
+ ARROW_R_DEV: "TRUE"
Review Comment:
Could you move this `env:` to `github.linux.sanitizers.yml`?
We don't need to customize them in `tasks.yml`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #46397:
URL: https://github.com/apache/arrow/pull/46397#discussion_r2085826578
##########
dev/tasks/tasks.yml:
##########
@@ -1081,30 +1081,17 @@ tasks:
r_tag: latest
flags: "-e LIBARROW_MINIMAL=TRUE"
- test-r-linux-sanitizer:
+ test-r-linux-sanitizers:
ci: github
- template: docker-tests/github.linux.yml
- params:
- env:
- R_PRUNE_DEPS: TRUE
- image: ubuntu-r-sanitizer
- timeout: 120
-
- test-r-clang-asan:
- ci: github
- template: docker-tests/github.linux.yml
+ template: r/github.linux.sanitizers.yml
params:
env:
R_PRUNE_DEPS: TRUE
- image: r-clang-asan
-
- test-r-clang-ubsan:
- ci: github
- template: docker-tests/github.linux.yml
- params:
- env:
- R_PRUNE_DEPS: TRUE
- image: r-clang-ubsan
+ R_ORG: "rhub"
+ R_IMAGE: "{{ '${{ matrix.config.r_image }}' }}"
+ R_TAG: "latest"
+ ARROW_R_DEV: "TRUE"
Review Comment:
I can, yeah. I was following other jobs here, but you're right that none of this varies at the tasks level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46394: [C++][R] gcc-UBSAN errors on CRAN [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46397:
URL: https://github.com/apache/arrow/pull/46397#issuecomment-2874919675
Revision: 45fcdd15f41d3ca0964c40b91f8c61ef25cf615f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6c92c64390](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6c92c64390)
|Task|Status|
|----|------|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/14987135992/job/42103063652)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org