You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by we...@apache.org on 2017/02/21 21:57:18 UTC
parquet-cpp git commit: PARQUET-888: Add missing virtual dtor.
Repository: parquet-cpp
Updated Branches:
refs/heads/master bc5c945ce -> 18fab9984
PARQUET-888: Add missing virtual dtor.
Author: Thomas Sanchez <th...@gmail.com>
Closes #256 from daedric/PARQUET-888 and squashes the following commits:
481dd6b [Thomas Sanchez] PARQUET-888: Add missing virtual dtor.
Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/18fab998
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/18fab998
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/18fab998
Branch: refs/heads/master
Commit: 18fab9984f58e1967ffa1d8c6737e8e76bdeb345
Parents: bc5c945
Author: Thomas Sanchez <th...@gmail.com>
Authored: Tue Feb 21 16:57:12 2017 -0500
Committer: Wes McKinney <we...@twosigma.com>
Committed: Tue Feb 21 16:57:12 2017 -0500
----------------------------------------------------------------------
src/parquet/file/writer.h | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/18fab998/src/parquet/file/writer.h
----------------------------------------------------------------------
diff --git a/src/parquet/file/writer.h b/src/parquet/file/writer.h
index ab32137..6a58cbf 100644
--- a/src/parquet/file/writer.h
+++ b/src/parquet/file/writer.h
@@ -38,6 +38,7 @@ class PARQUET_EXPORT RowGroupWriter {
// easily create test fixtures
// An implementation of the Contents class is defined in the .cc file
struct Contents {
+ virtual ~Contents() = default;
virtual int num_columns() const = 0;
virtual int64_t num_rows() const = 0;