Re: [PR] Static website [groovy-geb]

["sdelamo (via GitHub)" <gi...@apache.org>]

sdelamo commented on code in PR #256:
URL: https://github.com/apache/groovy-geb/pull/256#discussion_r1941220524


##########
doc/site/gradle.properties:
##########
@@ -0,0 +1 @@
+micronautVersion=3.10.1

Review Comment:
   Micronaut 3 is the latest version of Micronaut compatible with Java 11. This pull-request uses Micronaut to run the functional tests of the static site to ensure there are no broken links. 



##########
doc/site/src/test/groovy/geb/SiteSmokeSpec.groovy:
##########
@@ -55,18 +57,6 @@ class SiteSmokeSpec extends GebSpec {
         firstHeaderText == 'What is it?'
     }
 
-    @Unroll
-    void 'requesting a non-existing page - #pagePath'() {

Review Comment:
   the 404 pages will be handled by the static website hosting provider. 



##########
doc/manual/src/docs/asciidoc/140-project.adoc:
##########
@@ -29,7 +29,7 @@ mailto:geb-dev-unsubscribe@groovy.apache.org[Unsubscribe]
 
 === Committers
 
-* link:http://ldaley.com[Luke Daley]

Review Comment:
   `http://ldaley.com` is a broken link. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: geb-notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org