[jira] Resolved: (TRINIDAD-712) Do not generate final properties with the maven-faces-plugin

["Adam Winer (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TRINIDAD-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Winer resolved TRINIDAD-712.
---------------------------------

    Resolution: Invalid
      Assignee: Adam Winer

Regarding use of final, a lot of people would strongly disagree with you.  Final should be used whereever it makes sense.

Here, it makes absolute sense:  the true value is stored on the FacesBean.  Overriding the getter or setter convenience is useless, and final is exactly correct.

> Do not generate final properties with the maven-faces-plugin
> ------------------------------------------------------------
>
>                 Key: TRINIDAD-712
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-712
>             Project: MyFaces Trinidad
>          Issue Type: Wish
>          Components: Plugins
>    Affects Versions: 1.0.2-plugins
>         Environment: maven-faces-plugin version 1.0.2 from the maven repository
>            Reporter: Andrew Robinson
>            Assignee: Adam Winer
>
> It would be extremely beneficial to not have property methods generated as final by the maven-faces-plugin. 
> IMO, final should be reserved for constants and only on methods with rare exceptions and good reasons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.