You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/11/15 12:26:18 UTC

[GitHub] [qpid-proton] codecov-commenter commented on pull request #338: PROTON-2441: [cpp] Fix connection_options failover urls segfault

codecov-commenter commented on pull request #338:
URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-968861517


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#338](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a88d34) into [main](https://codecov.io/gh/apache/qpid-proton/commit/b788baad3e9d9ba028d3d115e272e94a30227e17?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b788baa) will **increase** coverage by `20.16%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 7a88d34 differs from pull request most recent head e1a3594. Consider uploading reports for the commit e1a3594 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/338/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #338       +/-   ##
   ===========================================
   + Coverage   68.17%   88.34%   +20.16%     
   ===========================================
     Files         356       47      -309     
     Lines       73024     2394    -70630     
   ===========================================
   - Hits        49787     2115    -47672     
   + Misses      23237      279    -22958     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cpp/src/connection\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0aW9uX29wdGlvbnMuY3Bw) | | |
   | [cpp/src/reconnect\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3RfdGVzdC5jcHA=) | | |
   | [c/src/core/object/list.c](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9vYmplY3QvbGlzdC5j) | | |
   | [cpp/include/proton/delivery.hpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2RlbGl2ZXJ5LmhwcA==) | | |
   | [cpp/examples/multithreaded\_client.cpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL211bHRpdGhyZWFkZWRfY2xpZW50LmNwcA==) | | |
   | [cpp/src/source.cpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9zb3VyY2UuY3Bw) | | |
   | [c/src/core/value\_dump.c](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS92YWx1ZV9kdW1wLmM=) | | |
   | [cpp/src/reconnect\_options\_impl.hpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9uc19pbXBsLmhwcA==) | | |
   | [cpp/include/proton/codec/forward\_list.hpp](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL2ZvcndhcmRfbGlzdC5ocHA=) | | |
   | [c/src/proactor/netaddr-internal.c](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvbmV0YWRkci1pbnRlcm5hbC5j) | | |
   | ... and [299 more](https://codecov.io/gh/apache/qpid-proton/pull/338/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b788baa...e1a3594](https://codecov.io/gh/apache/qpid-proton/pull/338?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org