[GitHub] [superset] hughhhh commented on a change in pull request #15576: feat: Make Google Sheets Dyanmic

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #15576:
URL: https://github.com/apache/superset/pull/15576#discussion_r666392449



##########
File path: superset/db_engine_specs/gsheets.py
##########
@@ -87,6 +105,50 @@ def extra_table_metadata(
 
         return {"metadata": metadata["extra"]}
 
+    @classmethod
+    def build_sqlalchemy_uri(cls) -> str:
+        # All gsheets return just the engine in the format of the uri,
+        # the above are temporary for csi
+        if not cls:

Review comment:
       remove this we dont need to check the cls method it come built int

##########
File path: superset/db_engine_specs/gsheets.py
##########
@@ -87,6 +105,50 @@ def extra_table_metadata(
 
         return {"metadata": metadata["extra"]}
 
+    @classmethod
+    def build_sqlalchemy_uri(cls) -> str:
+        # All gsheets return just the engine in the format of the uri,
+        # the above are temporary for csi
+        if not cls:
+            raise ValidationError("Invalid Engine")
+
+        return "gsheets://"
+
+    @classmethod
+    def get_parameters_from_uri(
+        cls,
+        encrypted_extra: Optional[
+            Dict[str, str]
+        ] = None,  # pylint: disable=unused-argument
+    ) -> Any:
+        # value = make_url(uri)

Review comment:
       remove this comment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org