[GitHub] [commons-io] jonfreedman commented on a change in pull request #32: Introduce Tailable interface to allow tailing of files accessed using alternative libraries such as jCIFS or commons-vfs

[GitBox <gi...@apache.org>]

jonfreedman commented on a change in pull request #32:
URL: https://github.com/apache/commons-io/pull/32#discussion_r704676213



##########
File path: src/main/java/org/apache/commons/io/input/Tailer.java
##########
@@ -556,4 +784,181 @@ private long readLines(final RandomAccessFile reader) throws IOException {
             return rePos;
         }
     }
+
+    /**
+     * Abstraction on {@link java.io.File} which allows substitution of remote files for example using jCIFS
+     *
+     * @since 2.12.0
+     */
+    public interface Tailable {
+        /**
+         * @return  The name of the file denoted by this tailable
+         */
+        String getName();

Review comment:
       I've renamed this to `getFileName` more descriptive but now inconsistent with `java.io.File#getName`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org