You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/07 02:38:29 UTC
Review Request 70148: Added `>`,
`<` and `>=` operators to `Value::Scalar`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70148/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added `>`, `<` and `>=` operators to `Value::Scalar`.
Diffs
-----
include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b
include/mesos/values.hpp 0d09729ccfa84c7ebb11e005fb30b8bb529d3120
src/common/values.cpp c788302b928747a1aed66efd4d654711410928f1
src/v1/values.cpp 5fd9dc5a03ec7b8f6ed31acb3f868764a45b2bfd
Diff: https://reviews.apache.org/r/70148/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70148: Added `>`,
`<` and `>=` operators to `Value::Scalar`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70148/#review213523
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On March 7, 2019, 2:38 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70148/
> -----------------------------------------------------------
>
> (Updated March 7, 2019, 2:38 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `>`, `<` and `>=` operators to `Value::Scalar`.
>
>
> Diffs
> -----
>
> include/mesos/v1/values.hpp 03a19ee44b3d7f801f7ca2a61f1d42d51e0c144b
> include/mesos/values.hpp 0d09729ccfa84c7ebb11e005fb30b8bb529d3120
> src/common/values.cpp c788302b928747a1aed66efd4d654711410928f1
> src/v1/values.cpp 5fd9dc5a03ec7b8f6ed31acb3f868764a45b2bfd
>
>
> Diff: https://reviews.apache.org/r/70148/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>