You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2019/07/01 12:59:00 UTC
[jira] [Comment Edited] (OAK-8446) Enable datastore consistency
check after completion of garbage collection
[ https://issues.apache.org/jira/browse/OAK-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876166#comment-16876166 ]
Julian Reschke edited comment on OAK-8446 at 7/1/19 12:58 PM:
--------------------------------------------------------------
Test failure:
{noformat}
[ERROR] consistencyCheckWithGc(org.apache.jackrabbit.oak.plugins.document.MongoBlobGCTest) Time elapsed: 1.265 s <<< ERROR!
java.lang.RuntimeException: Unable to start docker container: DockerConfig{name=MongoDB}
at com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:79)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: java.lang.ClassCastException: org.apache.jackrabbit.oak.plugins.document.mongo.MongoBlobStore cannot be cast to org.apache.jackrabbit.oak.plugins.blob.SharedDataStore
at org.apache.jackrabbit.oak.plugins.blob.MarkSweepGarbageCollector.checkConsistency(MarkSweepGarbageCollector.java:691)
at org.apache.jackrabbit.oak.plugins.document.MongoBlobGCTest.consistencyCheckWithGc(MongoBlobGCTest.java:308)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
... 19 more
{noformat}
It appears the new code assumes that every {{BlobStore}} is an instance of {{SharedBlobStore}}.
was (Author: reschke):
Test failure:
{noformat}
[ERROR] consistencyCheckWithGc(org.apache.jackrabbit.oak.plugins.document.MongoBlobGCTest) Time elapsed: 1.265 s <<< ERROR!
java.lang.RuntimeException: Unable to start docker container: DockerConfig{name=MongoDB}
at com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:79)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: java.lang.ClassCastException: org.apache.jackrabbit.oak.plugins.document.mongo.MongoBlobStore cannot be cast to org.apache.jackrabbit.oak.plugins.blob.SharedDataStore
at org.apache.jackrabbit.oak.plugins.blob.MarkSweepGarbageCollector.checkConsistency(MarkSweepGarbageCollector.java:691)
at org.apache.jackrabbit.oak.plugins.document.MongoBlobGCTest.consistencyCheckWithGc(MongoBlobGCTest.java:308)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at com.arakelian.docker.junit.DockerRule$StatementWithDockerRule.evaluate(DockerRule.java:76)
... 19 more
{noformat}
It appears the new code assumes that every `BloBStore` is an instance of `SharedBlobStore`.
> Enable datastore consistency check after completion of garbage collection
> -------------------------------------------------------------------------
>
> Key: OAK-8446
> URL: https://issues.apache.org/jira/browse/OAK-8446
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob-plugins, oak-run
> Reporter: Amit Jain
> Assignee: Julian Reschke
> Priority: Major
> Fix For: 1.16.0
>
>
> Optionally run datastore {{checkConsistency()}} after completion of DSGC to flag possible data loss immediately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)