[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #2005: allow IOBuf::append_user_data_with_meta to specify the lkey of rdma memory region

[GitBox <gi...@apache.org>]

Tuvie commented on code in PR #2005:
URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1028788462


##########
test/brpc_rdma_unittest.cpp:
##########
@@ -80,6 +80,7 @@ extern bool g_skip_rdma_init;
 }
 }
 
+static const size_t MAX_USER_MRS = 16;

Review Comment:
   should remove



##########
src/butil/iobuf.h:
##########
@@ -66,6 +66,7 @@ friend class IOBufCutter;
 public:
     static const size_t DEFAULT_BLOCK_SIZE = 8192;
     static const size_t INITIAL_CAP = 32; // must be power of 2
+    static const size_t BLOCK_META_OFFSET = 16;

Review Comment:
   should remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org