You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/11 12:37:50 UTC
[GitHub] [flink] XComp opened a new pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
XComp opened a new pull request #17764:
URL: https://github.com/apache/flink/pull/17764
## What is the purpose of the change
The dropdown menu introduced by [FLINK-21867](https://issues.apache.org/jira/browse/FLINK-21867) was not visualized due to missing imports. This issue is not present on `master`. It got fixed already as part of [903185d72c](https://github.com/apache/flink/commit/903185d72c#diff-b076916fff7fedff49389f5a54ec236ef413a1a43bc6a7b95406266d9fb12fe7R31). I added missing Modules to the imports to fix that.
## Brief change log
* Adds tooltip, select and icon modules
* Updates the corresponding HTML code accordingly
## Verifying this change
This change was tested manually.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #17764:
URL: https://github.com/apache/flink/pull/17764#discussion_r748049141
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/job.module.ts
##########
@@ -53,7 +56,10 @@ import { NzPopconfirmModule } from 'ng-zorro-antd/popconfirm';
NzDividerModule,
NzCollapseModule,
NzEmptyModule,
+ NzIconModule,
+ NzSelectModule,
NzSkeletonModule,
+ NzToolTipModule,
Review comment:
Same goes for the tooltip. Both modules, `NzToolTipModule` and `NzIconModule` were added on `master` in [903185d72c](https://github.com/apache/flink/commit/903185d72c#diff-b076916fff7fedff49389f5a54ec236ef413a1a43bc6a7b95406266d9fb12fe7R64-R66)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17764:
URL: https://github.com/apache/flink/pull/17764#issuecomment-966270710
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452710891426c74479ee7754c9968ee35eb1caaf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26362",
"triggerID" : "452710891426c74479ee7754c9968ee35eb1caaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452710891426c74479ee7754c9968ee35eb1caaf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26362)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17764:
URL: https://github.com/apache/flink/pull/17764#issuecomment-966270889
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 452710891426c74479ee7754c9968ee35eb1caaf (Thu Nov 11 12:41:08 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17764:
URL: https://github.com/apache/flink/pull/17764#issuecomment-966270710
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452710891426c74479ee7754c9968ee35eb1caaf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26362",
"triggerID" : "452710891426c74479ee7754c9968ee35eb1caaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452710891426c74479ee7754c9968ee35eb1caaf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26362)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17764:
URL: https://github.com/apache/flink/pull/17764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #17764:
URL: https://github.com/apache/flink/pull/17764#discussion_r748048127
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/job.module.ts
##########
@@ -53,7 +56,10 @@ import { NzPopconfirmModule } from 'ng-zorro-antd/popconfirm';
NzDividerModule,
NzCollapseModule,
NzEmptyModule,
+ NzIconModule,
Review comment:
FYI: I realized that the icon in the exception history was also not rendered. That's why I noticed that we should also add the Icon module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17764: [FLINK-24874][runtime-web] Fixes missing dropdown menu introduced in FLINK-21867
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17764:
URL: https://github.com/apache/flink/pull/17764#issuecomment-966270710
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452710891426c74479ee7754c9968ee35eb1caaf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "452710891426c74479ee7754c9968ee35eb1caaf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452710891426c74479ee7754c9968ee35eb1caaf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org