You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/08/24 02:38:50 UTC

Review Request 74561: updated to log plugin activities asynchronously

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74561/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-4375
    https://issues.apache.org/jira/browse/RANGER-4375


Repository: ranger


Description
-------

Updated Ranger to log plugin download activities asynchrously to avoid delays in plugins receiving policies/tags/roles/user-store


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 84f5ab168 
  security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java d84d772a9 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java de8a15823 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java ce02fdb8f 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 03ceb6280 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerPluginActivityLogger.java 26d63890f 


Diff: https://reviews.apache.org/r/74561/diff/1/


Testing
-------

- verified all tests pass successfully
- verified that plugin acticity logs are generated correctly
- verified that the plugins receive responses without waiting for activity log to be persisted


Thanks,

Madhan Neethiraj


Re: Review Request 74561: RANGER-4375: updated to log plugin activities asynchronously

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74561/#review225673
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Aug. 24, 2023, 2:38 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74561/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2023, 2:38 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4375
>     https://issues.apache.org/jira/browse/RANGER-4375
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Updated Ranger to log plugin download activities asynchrously to avoid delays in plugins receiving policies/tags/roles/user-store
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 84f5ab168 
>   security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java d84d772a9 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java de8a15823 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java ce02fdb8f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 03ceb6280 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerPluginActivityLogger.java 26d63890f 
> 
> 
> Diff: https://reviews.apache.org/r/74561/diff/2/
> 
> 
> Testing
> -------
> 
> - verified all tests pass successfully
> - verified that plugin acticity logs are generated correctly
> - verified that the plugins receive responses without waiting for activity log to be persisted
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 74561: RANGER-4375: updated to log plugin activities asynchronously

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74561/
-----------------------------------------------------------

(Updated Aug. 24, 2023, 6 a.m.)


Review request for ranger, Ankita Sinha, Abhay Kulkarni, Monika Kachhadiya, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.


Changes
-------

updated asynchronous logging for x_policy_export entry as well


Bugs: RANGER-4375
    https://issues.apache.org/jira/browse/RANGER-4375


Repository: ranger


Description
-------

Updated Ranger to log plugin download activities asynchrously to avoid delays in plugins receiving policies/tags/roles/user-store


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 84f5ab168 
  security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java d84d772a9 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java de8a15823 
  security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java ce02fdb8f 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 03ceb6280 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerPluginActivityLogger.java 26d63890f 


Diff: https://reviews.apache.org/r/74561/diff/3/

Changes: https://reviews.apache.org/r/74561/diff/2-3/


Testing
-------

- verified all tests pass successfully
- verified that plugin acticity logs are generated correctly
- verified that the plugins receive responses without waiting for activity log to be persisted


Thanks,

Madhan Neethiraj