You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/02/06 17:52:24 UTC
[PR] [MRESOLVER-491] Resolver should not have any "predefined" scope [maven-resolver]
cstamas opened a new pull request, #425:
URL: https://github.com/apache/maven-resolver/pull/425
It is duty of consumer application to define those. Also, no need for SPI either, as essentialy ONLY the dependency managers were using the "system" scope definition so far.
Now, client code, that instantianates these anyway are able to pass in predicate.
---
https://issues.apache.org/jira/browse/MRESOLVER-491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-491] Resolver should not have any "predefined" scope [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #425:
URL: https://github.com/apache/maven-resolver/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-491] Resolver should not have any "predefined" scope [maven-resolver]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #425:
URL: https://github.com/apache/maven-resolver/pull/425#discussion_r1480395574
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegateTestSupport.java:
##########
@@ -387,7 +379,7 @@ void testManagedVersionScope() throws DependencyCollectionException {
Dependency dependency = newDep("managed:aid:ext:ver");
CollectRequest request = new CollectRequest(dependency, singletonList(repository));
- session.setDependencyManager(new ClassicDependencyManager());
+ session.setDependencyManager(new ClassicDependencyManager(s -> Objects.equals(s, "system")));
Review Comment:
Why not `"system"::equals` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-491] Resolver should not have any "predefined" scope [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #425:
URL: https://github.com/apache/maven-resolver/pull/425#issuecomment-1931566778
@gnodet looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-491] Resolver should not have any "predefined" scope [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #425:
URL: https://github.com/apache/maven-resolver/pull/425#discussion_r1480416366
##########
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegateTestSupport.java:
##########
@@ -387,7 +379,7 @@ void testManagedVersionScope() throws DependencyCollectionException {
Dependency dependency = newDep("managed:aid:ext:ver");
CollectRequest request = new CollectRequest(dependency, singletonList(repository));
- session.setDependencyManager(new ClassicDependencyManager());
+ session.setDependencyManager(new ClassicDependencyManager(s -> Objects.equals(s, "system")));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MRESOLVER-491] Resolver should not have any "predefined" scope [maven-resolver]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #425:
URL: https://github.com/apache/maven-resolver/pull/425#discussion_r1480937529
##########
maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/manager/DependencyManagerTest.java:
##########
@@ -40,6 +41,8 @@
*/
public class DependencyManagerTest {
+ private final SystemScopePredicate systemScopePredicate = "system"::equals;
Review Comment:
Would it make sense to have this constant shared for the whole codebase (and deprecated) instead of having this predicate defined dozens of time in various places ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org