[jira] [Comment Edited] (MESOS-4812) Mesos fails to escape command health checks

["Andrew Schwartzmeyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376476#comment-16376476 ] 

Andrew Schwartzmeyer edited comment on MESOS-4812 at 2/26/18 7:41 AM:
----------------------------------------------------------------------

{noformat}
commit 3b6d58cfb
Author: Akash Gupta <ak...@hotmail.com>
Date:   Sat Feb 24 12:10:11 2018 -0800

    Fixed quoting bug in Docker executor command checks.

    The docker executor was wrapping the `docker exec` command with
    `sh -c ""`, which was causing problems due to quoting, especially on
    Windows. Now, the command health check simply runs `docker exec`
    without any wrapping.

    Review: https://reviews.apache.org/r/65419/

commit 8098ac239
Author: Akash Gupta <ak...@hotmail.com>
Date:   Sun Feb 25 13:41:15 2018 -0800

    Added test to check quotes in Docker executor health check.

    Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
    the Docker executor properly deals with quotes in the command health
    check to ensure that MESOS-4812 is fixed.

    Review: https://reviews.apache.org/r/65728/
{noformat}


was (Author: andschwa):
{noformat}
commit 3b6d58cfb
Author: Akash Gupta <ak...@hotmail.com>
Date:   Sat Feb 24 12:10:11 2018 -0800

    Fixed quoting bug in Docker executor command checks.

    The docker executor was wrapping the `docker exec` command with
    `sh -c ""`, which was causing problems due to quoting, especially on
    Windows. Now, the command health check simply runs `docker exec`
    without any wrapping.

    Review: https://reviews.apache.org/r/65419/
{noformat}

> Mesos fails to escape command health checks
> -------------------------------------------
>
>                 Key: MESOS-4812
>                 URL: https://issues.apache.org/jira/browse/MESOS-4812
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.25.0
>            Reporter: Lukas Loesche
>            Assignee: Akash Gupta
>            Priority: Major
>              Labels: health-check, mesosphere, tech-debt
>         Attachments: health_task.gif
>
>
> As described in https://github.com/mesosphere/marathon/issues/3333
> I would like to run a command health check
> {noformat}
> /bin/bash -c "</dev/tcp/$HOST/$PORT0"
> {noformat}
> The health check fails because Mesos, while running the command inside double quotes of a sh -c "" doesn't escape the double quotes in the command.
> If I escape the double quotes myself the command health check succeeds. But this would mean that the user needs intimate knowledge of how Mesos executes his commands which can't be right.
> I was told this is not a Marathon but a Mesos issue so am opening this JIRA. I don't know if this only affects the command health check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)