[GitHub] [trafficserver] masaori335 commented on a diff in pull request #10394: CID 1518583: Unchecked return value

["masaori335 (via GitHub)" <gi...@apache.org>]

masaori335 commented on code in PR #10394:
URL: https://github.com/apache/trafficserver/pull/10394#discussion_r1320991641


##########
plugins/experimental/cache_fill/cache_fill.cc:
##########
@@ -72,7 +72,10 @@ cont_check_cacheable(TSHttpTxn txnp)
     return false;
   }
   int lookupStatus;
-  TSHttpTxnCacheLookupStatusGet(txnp, &lookupStatus);
+  if (TSHttpTxnCacheLookupStatusGet(txnp, &lookupStatus) == TS_ERROR) {
+    TSError("[esi][%s] Couldn't get cache status of object", __FUNCTION__);

Review Comment:
   `esi` is the name of the other plugin. Please replace it with `cache_fill`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org