You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "gaurav7261 (via GitHub)" <gi...@apache.org> on 2023/12/13 21:00:35 UTC
[PR] fix(dashboard): load redshift date filter correctly [superset]
gaurav7261 opened a new pull request, #26271:
URL: https://github.com/apache/superset/pull/26271
add convert_dttm method for redshift
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
1. There was convert_dttm implementation missing for redshift
2. due to this date filter on redshit dataset not working
3. giving sqlalchemy error ```raise exc.CompileError(
sqlalchemy.exc.CompileError: Cannot compile Column object until its 'name' is assigned.```
query that was getting submitted: ```10:20:33,526:INFO:superset.connectors.sqla.models:SELECT day AS day
FROM (SELECT date_trunc('day', created_on) as day
FROM public.redshift_order) AS virtual_table
WHERE day IN (<name unknown>)```
### BEFORE SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1855159902
yes sure, adding, but why ci is not running, do you have any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1858199132
reopening to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 closed pull request #26271: fix(dashboard): load redshift date filter correctly
URL: https://github.com/apache/superset/pull/26271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1857723961
fixing ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1858198229
closed and open new pr as it was stucked in https://github.com/apache/superset/pull/26283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1858200372
somehow this is not working, so reopen PR: https://github.com/apache/superset/pull/26283
please check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "gaurav7261 (via GitHub)" <gi...@apache.org>.
gaurav7261 commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1858141345
@john-bodley added test and fix ci, one line got missed, forced pushed in my fork, i think it is stuck in processing updates, can you please help, will it take time ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1855385718
@gaurav7261 given it's your first PR, the first CI run needs to be approved by a committer. I've gone ahead and approved the run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): load redshift date filter correctly [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #26271:
URL: https://github.com/apache/superset/pull/26271#issuecomment-1854707973
Thanks @gaurav7261 for the PR. Would you mind adding some unit tests (similar to [this](https://github.com/apache/superset/blob/429e2a33c3ac5a4b035e0cb113bc6e1e63a39e4c/tests/unit_tests/db_engine_specs/test_kusto.py#L129-L144))?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org