You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/04/22 00:27:27 UTC
zeppelin git commit: [ZEPPELIN-2408] Should use $uibTooltip instead
of $tooltip
Repository: zeppelin
Updated Branches:
refs/heads/master 5124e62a1 -> dad440dd1
[ZEPPELIN-2408] Should use $uibTooltip instead of $tooltip
### What is this PR for?
Since we are using angular-bootstrap 2.5+, we should use `$uibTooltip` instead of `$tooltip`
otherwise we will get an error like the screenshot below.
See also https://github.com/angular-ui/bootstrap/issues/4591
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2048](https://issues.apache.org/jira/browse/ZEPPELIN-2408)
### How should this be tested?
1. open browser console
2. click the scatter chart.
3. shouldn't see an error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #2260 from 1ambda/ZEPPELIN-2048/fix-tooltip-provider and squashes the following commits:
e779c43 [1ambda] fix: Use
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/dad440dd
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/dad440dd
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/dad440dd
Branch: refs/heads/master
Commit: dad440dd16a3b67c11c8d2aec5a793ea7ec7defc
Parents: 5124e62
Author: 1ambda <1a...@gmail.com>
Authored: Wed Apr 19 10:25:53 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri Apr 21 17:27:25 2017 -0700
----------------------------------------------------------------------
.../popover-html-unsafe/popover-html-unsafe.directive.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/dad440dd/zeppelin-web/src/components/popover-html-unsafe/popover-html-unsafe.directive.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/popover-html-unsafe/popover-html-unsafe.directive.js b/zeppelin-web/src/components/popover-html-unsafe/popover-html-unsafe.directive.js
index d4dd546..a1f25b2 100644
--- a/zeppelin-web/src/components/popover-html-unsafe/popover-html-unsafe.directive.js
+++ b/zeppelin-web/src/components/popover-html-unsafe/popover-html-unsafe.directive.js
@@ -14,8 +14,8 @@
angular.module('zeppelinWebApp').directive('popoverHtmlUnsafe', popoverHtmlUnsafe)
-function popoverHtmlUnsafe ($tooltip) {
+function popoverHtmlUnsafe ($uibTooltip) {
'ngInject'
- return $tooltip('popoverHtmlUnsafe', 'popover', 'click')
+ return $uibTooltip('popoverHtmlUnsafe', 'popover', 'click')
}