You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/05/29 18:00:29 UTC
[GitHub] [bookkeeper] sudoHackIn opened a new pull request, #3297: Issue #472 Fix javadoc and build warnings
sudoHackIn opened a new pull request, #3297:
URL: https://github.com/apache/bookkeeper/pull/3297
Fix #472 #2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj merged pull request #3297: Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
Shoothzj merged PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3297: Issue #472 Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#issuecomment-1140838089
we need to update the checkstyle plugin version first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sudoHackIn commented on a diff in pull request #3297: Issue #472 Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
sudoHackIn commented on code in PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#discussion_r885072565
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -1680,7 +1680,7 @@ public ServerConfiguration setMajorCompactionThreshold(double threshold) {
}
/**
- * Get the maximum milliseconds to run major compaction. If <= 0 the
+ * Get the maximum milliseconds to run major compaction. If {@literal <=}0</code> the
Review Comment:
oh, sorry, my bad :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a diff in pull request #3297: Issue #472 Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#discussion_r884537175
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -1680,7 +1680,7 @@ public ServerConfiguration setMajorCompactionThreshold(double threshold) {
}
/**
- * Get the maximum milliseconds to run major compaction. If <= 0 the
+ * Get the maximum milliseconds to run major compaction. If {@literal <=}0</code> the
Review Comment:
```suggestion
* Get the maximum milliseconds to run major compaction. If {@literal <=} 0 the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3297: Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#issuecomment-1141543467
@sudoHackIn Sorry, I though the former error is caused by checkstyle version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sudoHackIn commented on a diff in pull request #3297: Issue #472 Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
sudoHackIn commented on code in PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#discussion_r885072565
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -1680,7 +1680,7 @@ public ServerConfiguration setMajorCompactionThreshold(double threshold) {
}
/**
- * Get the maximum milliseconds to run major compaction. If <= 0 the
+ * Get the maximum milliseconds to run major compaction. If {@literal <=}0</code> the
Review Comment:
oh, sorry, my bad :( fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sudoHackIn commented on pull request #3297: Issue #472 Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
sudoHackIn commented on PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#issuecomment-1141471325
> we need to update the checkstyle plugin version first.
To actual latest? [3.1.2?](https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-checkstyle-plugin/3.1.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3297: Fix javadoc and build warnings
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3297:
URL: https://github.com/apache/bookkeeper/pull/3297#issuecomment-1141543577
`OWASP Dependency Check` failure: both `google-http-client-gson` and `maven-settings` are not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org