You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/07/01 02:32:47 UTC
[jira] Created: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
--------------------------------------------------------------
Key: ZOOKEEPER-456
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
Project: Zookeeper
Issue Type: Improvement
Reporter: Mahadev konar
Assignee: Mahadev konar
Fix For: 3.3.0
CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-456:
--------------------------------------
Assignee: Patrick Hunt (was: Mahadev konar)
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-456:
-----------------------------------
Status: Patch Available (was: Open)
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804791#action_12804791 ]
Hadoop QA commented on ZOOKEEPER-456:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431373/ZOOKEEPER-456.patch
against trunk revision 902694.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/57/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/57/console
This message is automatically generated.
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-456:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks pat.
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805473#action_12805473 ]
Hudson commented on ZOOKEEPER-456:
----------------------------------
Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/])
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804850#action_12804850 ]
Mahadev konar commented on ZOOKEEPER-456:
-----------------------------------------
+1 the patch looks good.
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-456) CREATOR_ALL_ACL has unnecessary
PERMS.ADMIN in the declartion.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-456:
-----------------------------------
Attachment: ZOOKEEPER-456.patch
remove the unnecessary flag, otw the same, existing tests, etc...
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.