You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/08 09:25:53 UTC
[GitHub] [hbase] Apache9 opened a new pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
Apache9 opened a new pull request #1865:
URL: https://github.com/apache/hbase/pull/1865
…ause SCP to accidentally skip assigning a region
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1865:
URL: https://github.com/apache/hbase/pull/1865#issuecomment-640566666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1865:
URL: https://github.com/apache/hbase/pull/1865#issuecomment-640507533
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 43s | master passed |
| +1 :green_heart: | checkstyle | 1m 10s | master passed |
| +1 :green_heart: | spotbugs | 2m 6s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 27s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 4s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 32m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1865/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1865 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 480e55a470be 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fbf033735b |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1865/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1865:
URL: https://github.com/apache/hbase/pull/1865#discussion_r437076909
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1530,6 +1530,11 @@ protected void stopServiceThreads() {
LOG.debug("Stopping service threads");
+ // stop procedure executor priority to other services such as server manager and assignment
Review comment:
It will wait until all the worker threads are quit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #1865:
URL: https://github.com/apache/hbase/pull/1865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1865:
URL: https://github.com/apache/hbase/pull/1865#discussion_r437059050
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1530,6 +1530,11 @@ protected void stopServiceThreads() {
LOG.debug("Stopping service threads");
+ // stop procedure executor priority to other services such as server manager and assignment
Review comment:
Is this a synchronous call?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1530,6 +1530,11 @@ protected void stopServiceThreads() {
LOG.debug("Stopping service threads");
+ // stop procedure executor priority to other services such as server manager and assignment
Review comment:
Do you mean 'prior to other services'; i.e. before? If so, s/priority/prior/.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -485,6 +486,12 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
// UPDATE: HBCKServerCrashProcedure overrides isMatchingRegionLocation; this check can get
// in the way of our clearing out 'Unknown Servers'.
if (!isMatchingRegionLocation(regionNode)) {
+ // See HBASE-24117, though we have already changed the shutdown order, it is still worth
+ // double checking here to confirm that we do not skip assignment incorrectly.
+ if (!am.isRunning()) {
Review comment:
Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org