You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2020/02/18 08:40:08 UTC

Re: Review Request 72119: Extract ValidTxnManager from Driver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72119/
-----------------------------------------------------------

(Updated Feb. 18, 2020, 8:40 a.m.)


Review request for hive and Zoltan Haindrich.


Summary (updated)
-----------------

Extract ValidTxnManager from Driver


Bugs: HIVE-22868
    https://issues.apache.org/jira/browse/HIVE-22868


Repository: hive-git


Description
-------

~250 lines in driver are dedicated for the specific task of validating the transaction id list, and writing the valid write ids to the configuration. These should be put into a separate class.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1f8bc12fde 
  ql/src/java/org/apache/hadoop/hive/ql/ValidTxnManager.java PRE-CREATION 


Diff: https://reviews.apache.org/r/72119/diff/1/


Testing
-------

Tests are still passing.


Thanks,

Miklos Gergely