You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/17 10:28:39 UTC
[PR] API: Document supported transform names in Transforms.fromString [iceberg]
uros-b opened a new pull request, #17693:
URL: https://github.com/apache/iceberg/pull/17693
Adds Javadoc to `Transforms.fromString`, which currently has none. It documents the transform names the method recognizes — `identity`, `year`, `month`, `day`, `hour`, `void`, and the width-parameterized `truncate[N]` and `bucket[N]` — and that any other value is parsed as an `UnknownTransform`.
Javadoc-only; no behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#issuecomment-5507693722
soft ping for this ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#issuecomment-5346950760
cc @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho merged PR #17693:
URL: https://github.com/apache/iceberg/pull/17693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on code in PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#discussion_r3920344583
##########
api/src/main/java/org/apache/iceberg/transforms/Transforms.java:
##########
@@ -38,6 +38,17 @@ private Transforms() {}
private static final Pattern HAS_WIDTH = Pattern.compile("(\\w+)\\[(\\d+)\\]");
+ /**
+ * Parses a transform from its string representation.
+ *
+ * <p>Recognized transforms are {@code identity}, {@code year}, {@code month}, {@code day}, {@code
+ * hour}, {@code void}, and the width-parameterized {@code truncate[N]} and {@code bucket[N]} (for
+ * example, {@code truncate[16]} or {@code bucket[8]}). Any other value is parsed as an unknown
Review Comment:
technically, it can also throw an exception if the parameters are invalid, so probably say 'unrecognized names produce an UnknownTransform' (add javadoc link)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#issuecomment-5326285876
@huaxingao PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#issuecomment-5530373863
Thanks @uros-b !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Document supported transform names in Transforms.fromString [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #17693:
URL: https://github.com/apache/iceberg/pull/17693#discussion_r3924136442
##########
api/src/main/java/org/apache/iceberg/transforms/Transforms.java:
##########
@@ -38,6 +38,17 @@ private Transforms() {}
private static final Pattern HAS_WIDTH = Pattern.compile("(\\w+)\\[(\\d+)\\]");
+ /**
+ * Parses a transform from its string representation.
+ *
+ * <p>Recognized transforms are {@code identity}, {@code year}, {@code month}, {@code day}, {@code
+ * hour}, {@code void}, and the width-parameterized {@code truncate[N]} and {@code bucket[N]} (for
+ * example, {@code truncate[16]} or {@code bucket[8]}). Any other value is parsed as an unknown
Review Comment:
Thank you, reworded a bit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org