You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@solr.apache.org by Bruno Roustant <br...@apache.org> on 2023/10/25 17:19:46 UTC

PR to cleanup VersionBucket for the UpdateLog

Hi All,

I have a PR[1] to remove the "highest" field from VersionBucket (highest
doc version of the bucket).
By reading the code, I understand that this field is used for an
optimization in the case of a distributed update and non-leader checking a
doc version for an update. But I wondered about the usefulness of this
optimization.
I ran the SolrIndexing benchmark after removing this field (and cleaning
all the code used to maintain it), and it shows no perf difference.

By removing this field (a long) from VersionBucket, we can save 500 MB of
RAM per Core, because there are 64K VersionBucket. In addition it
removes/simplifies code.

I plan to merge the PR soon. Please comment there if you have any concerns.

Thanks

Bruno

[1] https://github.com/apache/solr/pull/2021#issuecomment-1774115830