You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by xy...@apache.org on 2015/06/07 03:47:58 UTC
hadoop git commit: HDFS-8116. Cleanup uncessary if
LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy
Battula.
Repository: hadoop
Updated Branches:
refs/heads/trunk 71de367c5 -> b61b48999
HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/b61b4899
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/b61b4899
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/b61b4899
Branch: refs/heads/trunk
Commit: b61b48999530851da177db2e8998858ffc01f77e
Parents: 71de367
Author: Xiaoyu Yao <xy...@apache.org>
Authored: Sat Jun 6 18:47:45 2015 -0700
Committer: Xiaoyu Yao <xy...@apache.org>
Committed: Sat Jun 6 18:47:45 2015 -0700
----------------------------------------------------------------------
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++
.../server/namenode/top/window/RollingWindowManager.java | 8 +++-----
2 files changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/b61b4899/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
index f7f7f98..21f587f 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
+++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
@@ -606,6 +606,9 @@ Release 2.8.0 - UNRELEASED
HDFS-8432. Introduce a minimum compatible layout version to allow downgrade
in more rolling upgrade use cases. (cnauroth)
+ HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from
+ RollingWindowManager. (Brahma Reddy Battula via xyao)
+
OPTIMIZATIONS
HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than
http://git-wip-us.apache.org/repos/asf/hadoop/blob/b61b4899/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
index 4759cc8..63438ff 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
@@ -187,11 +187,9 @@ public class RollingWindowManager {
*/
public TopWindow snapshot(long time) {
TopWindow window = new TopWindow(windowLenMs);
- if (LOG.isDebugEnabled()) {
- Set<String> metricNames = metricMap.keySet();
- LOG.debug("iterating in reported metrics, size={} values={}",
- metricNames.size(), metricNames);
- }
+ Set<String> metricNames = metricMap.keySet();
+ LOG.debug("iterating in reported metrics, size={} values={}",
+ metricNames.size(), metricNames);
for (Map.Entry<String, RollingWindowMap> entry : metricMap.entrySet()) {
String metricName = entry.getKey();
RollingWindowMap rollingWindows = entry.getValue();