svn commit: r1091236 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

[ma...@apache.org]

Author: markt
Date: Mon Apr 11 22:33:50 2011
New Revision: 1091236

URL: http://svn.apache.org/viewvc?rev=1091236&view=rev
Log:
Revert fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36362
JSP.8.3 does not limit the name of attributes defined in tag files

Modified:
    tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Parser.java?rev=1091236&r1=1091235&r2=1091236&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/compiler/Parser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Mon Apr 11 22:33:50 2011
@@ -593,18 +593,6 @@ class Parser implements TagConstants {
      */
     private void parseAttributeDirective(Node parent) throws JasperException {
         Attributes attrs = parseAttributes();
-        // JSP.8.3 says the variable created for each attribute must have the
-        // same name as the attribute. Therefore, the names must be valid Java
-        // identifiers
-        if (attrs != null && attrs.getLength() > 0) {
-            for (int i = 0; i < attrs.getLength(); i++) {
-                if ("name".equals(attrs.getLocalName(i)) &&
-                        !JspUtil.isJavaIdentifier(attrs.getValue(i))) {
-                    err.jspError(start, "jsp.error.identifier",
-                            attrs.getValue(i));
-                }
-            }
-        }
         new Node.AttributeDirective(attrs, start, parent);
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org