Re: [PR] [Fix-17817][Master] Fix task timeout alerts failed [dolphinscheduler]

["njnu-seafish (via GitHub)" <gi...@apache.org>]

njnu-seafish commented on code in PR #17818:
URL: https://github.com/apache/dolphinscheduler/pull/17818#discussion_r2644701175


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java:
##########
@@ -244,6 +244,13 @@ private void saveTaskTimeoutAlert(Alert alert, String content, int alertGroupId)
     public void sendTaskTimeoutAlert(WorkflowInstance workflowInstance,
                                      TaskInstance taskInstance,
                                      ProjectUser projectUser) {
+        assert projectUser != null;
+
+        // A null warningGroupId indicates that the user has explicitly configured a "no-alert" policy.
+        if (workflowInstance.getWarningGroupId() == null) {
+            return;
+        }

Review Comment:
   > If the user chooses not to send alerts, can this method be called? We need to filter at the upper layer. If the `sendTaskTimeoutAlert` method ultimately doesn't send an alert, that would be highly unusual.
   
   OK,will handle in TaskTimeoutLifecycleEventHandler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org