You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/05/04 23:22:59 UTC
Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/
-----------------------------------------------------------
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088
Repository: mesos
Description
-------
Added support for docker spec helper 'parseAuthConfig()'.
Diffs
-----
include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
Diff: https://reviews.apache.org/r/59017/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review175835
-----------------------------------------------------------
Ship it!
- Vinod Kone
On May 22, 2017, 6:03 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 6:03 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for docker spec helper 'parseAuthConfig()'.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
> src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
> src/tests/containerizer/docker_spec_tests.cpp d812592261aa46256bea287e768ca1f1c586aeff
>
>
> Diff: https://reviews.apache.org/r/59017/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/
-----------------------------------------------------------
(Updated May 22, 2017, 11:03 a.m.)
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088
Repository: mesos
Description
-------
Added support for docker spec helper 'parseAuthConfig()'.
Diffs (updated)
-----
include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
src/tests/containerizer/docker_spec_tests.cpp d812592261aa46256bea287e768ca1f1c586aeff
Diff: https://reviews.apache.org/r/59017/diff/3/
Changes: https://reviews.apache.org/r/59017/diff/2-3/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/
-----------------------------------------------------------
(Updated May 10, 2017, 5:47 a.m.)
Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088
Repository: mesos
Description
-------
Added support for docker spec helper 'parseAuthConfig()'.
Diffs (updated)
-----
include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
Diff: https://reviews.apache.org/r/59017/diff/2/
Changes: https://reviews.apache.org/r/59017/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174083
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/docker/spec.hpp
Line 76 (original), 76 (patched)
<https://reviews.apache.org/r/59017/#comment247193>
How about "parsing the docker config from a JSON object" and "from a string"?
- Chun-Hung Hsiao
On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 11:22 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for docker spec helper 'parseAuthConfig()'.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
> src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
>
>
> Diff: https://reviews.apache.org/r/59017/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On May 9, 2017, 11:25 p.m., Vinod Kone wrote:
> > include/mesos/docker/spec.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/59017/diff/1/?file=1709140#file1709140line83>
> >
> > no unit test for this?
>
> Gilbert Song wrote:
> This helper was tested in unit test when the parameter is a JSON object. Thought no duplicate unit test needed for the `string` parameter since they are the same implementation.
Since the string version calls the JSON version, how about just testing the string version instead so we have both functions covered?
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
-----------------------------------------------------------
On May 10, 2017, 12:47 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 12:47 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for docker spec helper 'parseAuthConfig()'.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
> src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
>
>
> Diff: https://reviews.apache.org/r/59017/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Gilbert Song <so...@gmail.com>.
> On May 9, 2017, 4:25 p.m., Vinod Kone wrote:
> > include/mesos/docker/spec.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/59017/diff/1/?file=1709140#file1709140line83>
> >
> > no unit test for this?
>
> Gilbert Song wrote:
> This helper was tested in unit test when the parameter is a JSON object. Thought no duplicate unit test needed for the `string` parameter since they are the same implementation.
>
> Chun-Hung Hsiao wrote:
> Since the string version calls the JSON version, how about just testing the string version instead so we have both functions covered?
good idea.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
-----------------------------------------------------------
On May 10, 2017, 5:47 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 5:47 a.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for docker spec helper 'parseAuthConfig()'.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
> src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
>
>
> Diff: https://reviews.apache.org/r/59017/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Gilbert Song <so...@gmail.com>.
> On May 9, 2017, 4:25 p.m., Vinod Kone wrote:
> > include/mesos/docker/spec.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/59017/diff/1/?file=1709140#file1709140line83>
> >
> > no unit test for this?
This helper was tested in unit test when the parameter is a JSON object. Thought no duplicate unit test needed for the `string` parameter since they are the same implementation.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
-----------------------------------------------------------
On May 4, 2017, 4:22 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 4:22 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for docker spec helper 'parseAuthConfig()'.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
> src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
>
>
> Diff: https://reviews.apache.org/r/59017/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 59017: Added support for docker spec helper
'parseAuthConfig()'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
-----------------------------------------------------------
include/mesos/docker/spec.hpp
Line 76 (original), 76 (patched)
<https://reviews.apache.org/r/59017/#comment247531>
s/as a/from a/
include/mesos/docker/spec.hpp
Lines 82 (patched)
<https://reviews.apache.org/r/59017/#comment247532>
s/as a/from a/
include/mesos/docker/spec.hpp
Lines 83 (patched)
<https://reviews.apache.org/r/59017/#comment247533>
no unit test for this?
- Vinod Kone
On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 11:22 p.m.)
>
>
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for docker spec helper 'parseAuthConfig()'.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03
> src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17
>
>
> Diff: https://reviews.apache.org/r/59017/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>