[jira] Commented: (DIRSERVER-258) NormalizationService is not handling correctly a Name with a comma followed by a space in it: for instance "text1, text2"

["Giamma (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/DIRSERVER-258?page=comments#action_12365987 ] 

Giamma commented on DIRSERVER-258:
----------------------------------

ok I researched this a bit more.

I was not able to reproduce the problem in the default standard partition (ou=system). but the problem is still there.
your backend (org.apache.ldap.server.partition.impl.btree.jdbm.JdbmDirectoryPartition) is a bit more powerful and is able to hanlde the
lack of a space in the DN.

This is how I reproduced it.
1) Using an LDAP browser (like JXplorer), under ou=system, create a new organization (organizationalUnit) called "corporate category, operations"
2) the creating will work just fine
3) click on it with an LDAP browser. This will trigger in the LDAP server a call to DefaultDirectoryPartitionNexus.hasEntry.

If you look in here the DN being passed is:
ou=corporate category\,operations,ou=system
and not
ou=corporate category\, operations,ou=system

so again there is a missing space.

Now your backend is smart to find this entry even wthout the missing space, but I think this is a bug.
My backend (the custom partition that I wrote) is not smart enough to search without the space.
I could add an hack but it would have peformance consequences.

I think the parsing should do the right thing.

My 2 cents.


> NormalizationService is not handling correctly a Name with a comma followed by a space in it: for instance "text1, text2"
> -------------------------------------------------------------------------------------------------------------------------
>
>          Key: DIRSERVER-258
>          URL: http://issues.apache.org/jira/browse/DIRSERVER-258
>      Project: Directory ApacheDS
>         Type: Bug
>     Versions: pre-1.0
>  Environment: XP
>     Reporter: Giamma
>     Assignee: Alex Karasulu
>      Fix For: 1.0-RC1
>  Attachments: Direct Report View.ldif
>
> In my custom partition I have organizations with various special characters in their name, for instance:
> "text1=text2"
> "text1 text2"
> "text1,text2"
> The 3 above all work fine.
> But the following won't be normilized correctly:
> "text1= text2"
> "text2, text2"
> They are normilized by NormalizationService.search or NormalizationService.hasEntry as this:
> "text1= text2" --> "text1=text2"
> "text2, text2" --> "text1,text2"
> The space after the = or the , are skipped.
> I think the code doing this is coming from antrl.
> I tried using the latest 2.7.5 but the problem is still there.
> I think the actual class with the bug is LLKParser.
> I didn't download the code so i am not sure what's wrong.
> I believe this is a regression as the same test case used to work with a previous
> version of apache DS.
> Let me know if you need anything more from me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira