You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/02 13:05:23 UTC
[GitHub] [skywalking-data-collect-protocol] wu-sheng opened a new pull
request #9: Add browser perf service for client-js project
wu-sheng opened a new pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9
According to discussion at https://docs.google.com/document/d/1125WnFCsJnZ98m3H7hplgfkv5MXGJoYdPj-OSr64cDo/edit#. I summarize it to this PR. Please review, @Fine0830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] arugal commented on a change in
pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362468667
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
+ repeated BrowserErrorLog logs = 4;
+
+}
+
+message BrowserErrorLog {
+ int64 time = 1;
+ string catalog = 2;
+ string grade = 3;
+ string message = 4;
+ int32 line = 5;
+ string stack = 6;
+}
+
+message PerfDetail {
+ // Unit of all time related field should be `ms`.
+ int32 redirectTime = 1;
+ int32 dnsTime = 2;
+ int32 reqTime = 3;
+ // analysis dom tree time
+ int32 domAnalysisTime = 4;
+ int32 domeReadyTime = 5;
+ // page blank time
+ int32 blankTime = 6;
+}
Review comment:
`PerfDetail` is not used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] Fine0830 commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362473858
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
+ repeated BrowserErrorLog logs = 4;
+ PerfDetail perfDetail = 5;
+}
+
+message BrowserErrorLog {
+ int64 time = 1;
Review comment:
I think there is lack of col and error url fields for error log. what is the time field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362471860
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
+ repeated BrowserErrorLog logs = 4;
+ PerfDetail perfDetail = 5;
+}
+
+message BrowserErrorLog {
+ int64 time = 1;
+ string catalog = 2;
+ string grade = 3;
+ string message = 4;
+ int32 line = 5;
+ string stack = 6;
+}
+
+message PerfDetail {
+ // Unit of all time related field should be `ms`.
+ int32 redirectTime = 1;
+ int32 dnsTime = 2;
+ int32 reqTime = 3;
+ // analysis dom tree time
+ int32 domAnalysisTime = 4;
+ int32 domeReadyTime = 5;
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362470408
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
+ repeated BrowserErrorLog logs = 4;
+ PerfDetail perfDetail = 5;
+}
+
+message BrowserErrorLog {
+ int64 time = 1;
+ string catalog = 2;
+ string grade = 3;
+ string message = 4;
+ int32 line = 5;
+ string stack = 6;
+}
+
+message PerfDetail {
+ // Unit of all time related field should be `ms`.
+ int32 redirectTime = 1;
+ int32 dnsTime = 2;
+ int32 reqTime = 3;
+ // analysis dom tree time
+ int32 domAnalysisTime = 4;
+ int32 domeReadyTime = 5;
Review comment:
`dome`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362475049
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
+ repeated BrowserErrorLog logs = 4;
+ PerfDetail perfDetail = 5;
+}
+
+message BrowserErrorLog {
+ int64 time = 1;
Review comment:
Fixed. And `time` removed. We will use the time of OAP server, is that acceptable? In order to avoid TZ and time difference issue at the client-side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #9:
Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] Fine0830 commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362476669
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
Review comment:
Do we need a string field for serviceName instead of serviceId? I think name can be use in rocketbot ui.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362478006
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
Review comment:
You will need a serviceId to register version id (notice, it is an int32 type).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362469256
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
+ repeated BrowserErrorLog logs = 4;
+
+}
+
+message BrowserErrorLog {
+ int64 time = 1;
+ string catalog = 2;
+ string grade = 3;
+ string message = 4;
+ int32 line = 5;
+ string stack = 6;
+}
+
+message PerfDetail {
+ // Unit of all time related field should be `ms`.
+ int32 redirectTime = 1;
+ int32 dnsTime = 2;
+ int32 reqTime = 3;
+ // analysis dom tree time
+ int32 domAnalysisTime = 4;
+ int32 domeReadyTime = 5;
+ // page blank time
+ int32 blankTime = 6;
+}
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] Fine0830 commented on a change
in pull request #9: Add browser perf service for client-js project
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #9: Add browser perf service for client-js project
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/9#discussion_r362479151
##########
File path: browser/BrowserPerf.proto
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.language.agent";
+
+import "common/common.proto";
+
+// Collect performance raw data from browser.
+service BrowserPerfService {
+ rpc collect (stream BrowserPerfData) returns (Commands) {
+ }
+}
+
+message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 3;
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services