[jira] [Commented] (MINIFI-450) PullHttpChangeIngestor needs to properly close OkHttp response

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500668#comment-16500668 ] 

ASF GitHub Bot commented on MINIFI-450:
---------------------------------------

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi-minifi/pull/129

    MINIFI-450 Handling closing of HTTP response in PullHttpChangeIngestor.

    Thank you for submitting a contribution to Apache NiFi - MiNiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/nifi-minifi MINIFI-450

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit a6b7842eada964121a08bad14d0acdf5cdd9424c
Author: Aldrin Piri <al...@...>
Date:   2018-06-04T18:18:15Z

    MINIFI-450 Handling closing of HTTP response in PullHttpChangeIngestor.

----


> PullHttpChangeIngestor needs to properly close OkHttp response 
> ---------------------------------------------------------------
>
>                 Key: MINIFI-450
>                 URL: https://issues.apache.org/jira/browse/MINIFI-450
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>            Reporter: Joseph Percivall
>            Assignee: Aldrin Piri
>            Priority: Major
>             Fix For: 0.5.0
>
>
> Same as NIFI-5085 and NIFI-5086, PullHttpChangeIngestor does not close the response as it should[1]
>  
> [1] https://github.com/apache/nifi-minifi/blob/master/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/configuration/ingestors/PullHttpChangeIngestor.java#L253



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)