You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yuseok89 (via GitHub)" <gi...@apache.org> on 2026/07/05 09:04:43 UTC
[PR] [AIP-94] Mark dags list-runs/list-jobs/report/clear as migrated to airflowctl [airflow]
yuseok89 opened a new pull request, #69409:
URL: https://github.com/apache/airflow/pull/69409
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related: #68402
Marks the `dags` CLI commands (`list-runs`, `list-jobs`, `report`, `clear`) as migrated to `airflowctl` by adding the `deprecated_for_airflowctl` marker.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Opus 4.8
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs as migrated to airflowctl [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3525267237
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -692,6 +693,7 @@ def dag_list_import_errors(args, *, session: Session = NEW_SESSION) -> None:
sys.exit(1)
+@deprecated_for_airflowctl("airflowctl dags report")
Review Comment:
Removed it from this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs as migrated to airflowctl [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3525268882
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -727,6 +729,7 @@ def dag_report(args) -> None:
)
+@deprecated_for_airflowctl("airflowctl dags list-jobs")
Review Comment:
The list-jobs marker looks better added after the PR you pointed out merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs/list-jobs/report/clear as migrated to airflowctl [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3524952272
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -727,6 +729,7 @@ def dag_report(args) -> None:
)
+@deprecated_for_airflowctl("airflowctl dags list-jobs")
Review Comment:
This one doesn't either. There is a `airflowctl jobs list` command, but it can't filter by dag, so it's not fully matched with the cli.
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -758,6 +761,7 @@ def dag_list_jobs(args, dag: DAG | None = None, *, session: Session = NEW_SESSIO
)
+@deprecated_for_airflowctl("airflowctl dags list-runs")
Review Comment:
Same here. We currently have `airflowctl dagrun list` which lists Dag runs (optionally filtered by dag id, state, etc), so it's very similar. That being said, if there are plans to extend the dag operations to match the command names exactly, then maybe it makes sense as is.
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -692,6 +693,7 @@ def dag_list_import_errors(args, *, session: Session = NEW_SESSION) -> None:
sys.exit(1)
+@deprecated_for_airflowctl("airflowctl dags report")
Review Comment:
This command doesn't exist yet in airflowctl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs/list-jobs/report/clear as migrated to airflowctl [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3524953560
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -758,6 +761,7 @@ def dag_list_jobs(args, dag: DAG | None = None, *, session: Session = NEW_SESSIO
)
+@deprecated_for_airflowctl("airflowctl dags list-runs")
Review Comment:
Same here. We currently have `airflowctl dagrun list` which lists Dag runs (optionally filtered by dag id, state, etc), so it's very similar. That being said, if there are plans to extend the dag operations to match the cli command names exactly, then maybe it makes sense as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs as migrated to airflowctl [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3525264813
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -758,6 +761,7 @@ def dag_list_jobs(args, dag: DAG | None = None, *, session: Session = NEW_SESSIO
)
+@deprecated_for_airflowctl("airflowctl dags list-runs")
Review Comment:
Thank you so much. This was my mistake for going off the meta-issue alone without double-checking against the actual airflowctl commands. I've updated the PR to keep only the marker whose airflowctl equivalent actually exists and fully matches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs as migrated to airflowctl [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3525388203
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -758,6 +761,7 @@ def dag_list_jobs(args, dag: DAG | None = None, *, session: Session = NEW_SESSIO
)
+@deprecated_for_airflowctl("airflowctl dags list-runs")
Review Comment:
All good, thanks for making the update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs/list-jobs/report/clear as migrated to airflowctl [airflow]
Posted by "justinpakzad (via GitHub)" <gi...@apache.org>.
justinpakzad commented on code in PR #69409:
URL: https://github.com/apache/airflow/pull/69409#discussion_r3524952272
##########
airflow-core/src/airflow/cli/commands/dag_command.py:
##########
@@ -727,6 +729,7 @@ def dag_report(args) -> None:
)
+@deprecated_for_airflowctl("airflowctl dags list-jobs")
Review Comment:
This one doesn't either. There is a `airflowctl jobs list` command, but it can't filter by dag, so it's not fully matched with the cli.
Edit: There is actually a PR #68616 that will align the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AIP-94] Mark dags list-runs as migrated to airflowctl [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #69409:
URL: https://github.com/apache/airflow/pull/69409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org