[GitHub] [spark] MaxGekk commented on pull request #38161: [SPARK-40714][SQL] Remove `PartitionAlreadyExistsException`

[GitBox <gi...@apache.org>]

MaxGekk commented on PR #38161:
URL: https://github.com/apache/spark/pull/38161#issuecomment-1273217736

   > this looks like a big change on SupportsAtomicPartitionManagement and SupportsPartitionManagement.
   
   I think it is right time to change the APIs since they are not broadly used so far. I guess, it will be difficult to predict which of `PartitionAlreadyExistsException` and `PartitionsAlreadyExistException` to expect from particular Spark DDL, and user apps will be written in the way to handle both exception. I think we should avoid this from the beginning, and to don't introduce unnecessary complexity in the user code. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org