You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/22 02:33:18 UTC

[GitHub] [apisix-java-plugin-runner] iamayushdas opened a new pull request #36: refactor: added config.json and directory refactored

iamayushdas opened a new pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36


   config.json added
   refactored directories


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655840546



##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,10 @@
+{
+    "version": 1.0,
+    "sidebar": [
+      {
+        "type": "category",
+        "label": "Installation",
+        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]

Review comment:
       Okay captain

##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,20 @@
+{
+    "version": 0.1,
+    "sidebar": [
+      {
+        "type": "category",

Review comment:
       oh yes , I forgot, it done now
   

##########
File path: docs/en/latest/config.json
##########
@@ -1,10 +1,20 @@
 {
-    "version": 1.0,
+    "version": 0.1,
     "sidebar": [
       {
         "type": "category",
-        "label": "Installation",
-        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]
+        "label": "Development",
+        "id": "development"
+      },
+      {
+        "type": "category",
+        "label": "Working",

Review comment:
       I thought this will be more apt. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865476739






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] juzhiyuan commented on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-866029616


   @iamayushdas Because this PR is out of date from main branch :) so we have to resolve those conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655839812



##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,10 @@
+{
+    "version": 1.0,

Review comment:
       It seems @tzssangglass wants to make a `0.1` release:
   https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-864721810

##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,10 @@
+{
+    "version": 1.0,
+    "sidebar": [
+      {
+        "type": "category",
+        "label": "Installation",
+        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]

Review comment:
       IMHO, each item should have separate sidebar entry, and they are not all about "Installation".

##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,20 @@
+{
+    "version": 0.1,
+    "sidebar": [
+      {
+        "type": "category",

Review comment:
       The type is incorrect, see: https://github.com/apache/apisix/blob/2707fda3eb7b23d995ac23ecf4a17000dd765855/docs/en/latest/config.json#L164 as an example




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas edited a comment on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-866067916


   resolving conflict in new PR, CLOSING THIS
   
   recreated here #38 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865977505


   > > hi, pls resolve conflicting files
   > 
   > I don't think conflicts are from my side
   
   try pulling the latest code from the `main` branch of upstream?
   I see this 
   ![image](https://user-images.githubusercontent.com/30819887/122931488-859f4300-d39f-11eb-86bc-05e0f58bc73b.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865476739


   @juzhiyuan have a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865672127


   hi, pls resolve conflicting files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655869025



##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,20 @@
+{
+    "version": 0.1,
+    "sidebar": [
+      {
+        "type": "category",

Review comment:
       oh yes , I forgot, it done now
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655866653



##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,20 @@
+{
+    "version": 0.1,
+    "sidebar": [
+      {
+        "type": "category",

Review comment:
       The type is incorrect, see: https://github.com/apache/apisix/blob/2707fda3eb7b23d995ac23ecf4a17000dd765855/docs/en/latest/config.json#L164 as an example




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865672127


   hi, pls resolve conflicting files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865503302


   > LGTM except the version and sidebar :)
   
   fixed, but what's the conflicts here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655839812



##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,10 @@
+{
+    "version": 1.0,

Review comment:
       It seems @tzssangglass wants to make a `0.1` release:
   https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-864721810

##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,10 @@
+{
+    "version": 1.0,
+    "sidebar": [
+      {
+        "type": "category",
+        "label": "Installation",
+        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]

Review comment:
       IMHO, each item should have separate sidebar entry, and they are not all about "Installation".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655840546



##########
File path: docs/en/latest/config.json
##########
@@ -0,0 +1,10 @@
+{
+    "version": 1.0,
+    "sidebar": [
+      {
+        "type": "category",
+        "label": "Installation",
+        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]

Review comment:
       Okay captain




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] juzhiyuan commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655887495



##########
File path: docs/en/latest/config.json
##########
@@ -1,10 +1,20 @@
 {
-    "version": 1.0,
+    "version": 0.1,
     "sidebar": [
       {
         "type": "category",
-        "label": "Installation",
-        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]
+        "label": "Development",
+        "id": "development"
+      },
+      {
+        "type": "category",
+        "label": "Working",

Review comment:
       🤔 Not sure if we have a better label?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-866067916


   resolving conflict in new PR, CLOSING THIS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655888103



##########
File path: docs/en/latest/config.json
##########
@@ -1,10 +1,20 @@
 {
-    "version": 1.0,
+    "version": 0.1,
     "sidebar": [
       {
         "type": "category",
-        "label": "Installation",
-        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]
+        "label": "Development",
+        "id": "development"
+      },
+      {
+        "type": "category",
+        "label": "Working",

Review comment:
       I thought this will be more apt. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] juzhiyuan commented on a change in pull request #36: refactor: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#discussion_r655887495



##########
File path: docs/en/latest/config.json
##########
@@ -1,10 +1,20 @@
 {
-    "version": 1.0,
+    "version": 0.1,
     "sidebar": [
       {
         "type": "category",
-        "label": "Installation",
-        "items": [ "development", "how-it-works", "the-internal-of-apisix-java-plugin-runner" ]
+        "label": "Development",
+        "id": "development"
+      },
+      {
+        "type": "category",
+        "label": "Working",

Review comment:
       🤔 Not sure if we have a better label?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas closed pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] iamayushdas commented on pull request #36: docs: added config.json and directory refactored

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #36:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/36#issuecomment-865673466


   > hi, pls resolve conflicting files
   > 
   > 
   
   I don't think conflicts are from my side


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org