[jira] [Commented] (HBASE-14361) ReplicationSink should create Connection instances lazily

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737922#comment-14737922 ] 

Hadoop QA commented on HBASE-14361:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12754996/HBASE-14361-0.98.patch
  against 0.98 branch at commit a11bb2a933ad799546e7179fdf6ce75e3e22d44b.
  ATTACHMENT ID: 12754996

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 22 warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15512//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15512//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15512//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15512//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15512//console

This message is automatically generated.

> ReplicationSink should create Connection instances lazily
> ---------------------------------------------------------
>
>                 Key: HBASE-14361
>                 URL: https://issues.apache.org/jira/browse/HBASE-14361
>             Project: HBase
>          Issue Type: Task
>          Components: Replication
>            Reporter: Nick Dimiduk
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
>         Attachments: HBASE-14361-0.98.patch, HBASE-14361.patch, hmaster.log
>
>
> Over on HBASE-12911 I have a patch that registers Connection instances with the metrics system. In both standalone server and tll client applications, I was surprised to see multiple connection objects showing up that are unused. These are pretty heavy objects, including lots of client threads for the batch pool. We should track these down and remove them -- if they're not some kind of phantom artifacts of my WIP patch over there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)