You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/21 02:21:24 UTC

[GitHub] [incubator-kvrocks] tufitko commented on a diff in pull request #902: feat: impl FilterBlobByKey for SubKeyFilter

tufitko commented on code in PR #902:
URL: https://github.com/apache/incubator-kvrocks/pull/902#discussion_r975974445


##########
src/compact_filter.cc:
##########
@@ -108,7 +110,12 @@ bool SubKeyFilter::Filter(int level,
                                   std::string *new_value,
                                   bool *modified) const {
   InternalKey ikey(key, stor_->IsSlotIdEncoded());
-  bool result = IsKeyExpired(ikey, value);
+  Metadata metadata(kRedisNone, false);
+  if (GetMetadata(ikey, &metadata)) {
+    return true;
+  }

Review Comment:
   I didn't invent a better name. `FindMetadata`, `FillMetadata`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org