You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by roshannaik <gi...@git.apache.org> on 2016/02/05 19:39:42 UTC

[GitHub] storm pull request: STORM-1526 Improve Storm core performance

Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1080#discussion_r52054870
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -58,7 +58,7 @@
       (.prepare grouping context (GlobalStreamId. component-id stream-id) target-tasks)
       (if (instance? LoadAwareCustomStreamGrouping grouping)
         (fn [task-id ^List values load]
    -      (.chooseTasks grouping task-id values load))
    +      (.chooseTasks ^LoadAwareCustomStreamGrouping grouping task-id values load))
    --- End diff --
    
    @abhishekagarwal87  i see several places in that file which are missing type hints. Might be safer to limit this PR to just this perf issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---