[GitHub] [kafka] divijvaidya commented on pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #13572:
URL: https://github.com/apache/kafka/pull/13572#issuecomment-1513029513

   @showuon That's a good point. The problem I want to solve here is to ensure that tests are using the same code that SocketServer is using. If we implement a method in `TestUtils` then the tests may not catch bugs when `SocketServer` was modified but `TestUtils` wasn't. But I agree with your concern about taking a dependency on core.
   
   I agree with ignoring the part of my suggestion to modify tests (suggestion 2 in my previous comment) for now. But let's keep the part about adding a unit test to verify that this configuration was added (suggestion 4 in my previous comment).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org