You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/04/28 19:10:16 UTC

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/864

    [ZEPPELIN-779] Dynamic form doesn't work with python3

    ### What is this PR for?
    
    When pyspark interpreter configured to use python3, dynamic form doesn't work.
    https://issues.apache.org/jira/browse/ZEPPELIN-779
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Convert map to list
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-779
    
    ### How should this be tested?
    configure pyspark interpreter to use python3 and run
    ```
    %pyspark
    print("Hello "+z.select("day", [("1","mon"),
                                    ("2","tue"),
                                    ("3","wed"),
                                    ("4","thurs"),
                                    ("5","fri"),
                                    ("6","sat"),
                                    ("7","sun")]))
    ```
    
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-779

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #864
    
----
commit ba2db3bb4d5624c23e93b99af991b3992e8b9a1b
Author: Lee moon soo <mo...@apache.org>
Date:   2016-04-28T17:07:03Z

    Convert map to list

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/864#issuecomment-215608571
  
    I didn't know in python 3, map(list()) returns a map!
    http://stackoverflow.com/questions/1303347/getting-a-map-to-return-a-list-in-python-3-x
    
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/864


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/864#issuecomment-215932798
  
    I'm merging it into master if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/864


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-779] Dynamic form doesn...

Posted by Leemoonsoo <gi...@git.apache.org>.
GitHub user Leemoonsoo reopened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/864

    [ZEPPELIN-779] Dynamic form doesn't work with python3

    ### What is this PR for?
    
    When pyspark interpreter configured to use python3, dynamic form doesn't work.
    https://issues.apache.org/jira/browse/ZEPPELIN-779
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Convert map to list
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-779
    
    ### How should this be tested?
    configure pyspark interpreter to use python3 and run
    ```
    %pyspark
    print("Hello "+z.select("day", [("1","mon"),
                                    ("2","tue"),
                                    ("3","wed"),
                                    ("4","thurs"),
                                    ("5","fri"),
                                    ("6","sat"),
                                    ("7","sun")]))
    ```
    
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-779

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #864
    
----
commit ba2db3bb4d5624c23e93b99af991b3992e8b9a1b
Author: Lee moon soo <mo...@apache.org>
Date:   2016-04-28T17:07:03Z

    Convert map to list

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---