You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dmeaux (via GitHub)" <gi...@apache.org> on 2024/01/29 10:59:15 UTC

[PR] Simplify-France-Regions-Map [superset]

dmeaux opened a new pull request, #26848:
URL: https://github.com/apache/superset/pull/26848

   fix(dashboard): simplify and reproject France Regions map
   
   ### SUMMARY
   The previous version of the GeoJSON file was in EPSG 2154 projection and contained a high level of detail in the boundaries. This version has been reprojected to WGS84 (EPSG 4326) with the boundaries simplified, reducing the file size from ~12 MB to less than 900 KB.
   
   ### BEFORE SCREENSHOTS
   <img src="https://private-user-images.githubusercontent.com/9881262/300395181-8158b978-9e10-4cc1-a46f-a548a3a9d50b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY1MjQ1MzgsIm5iZiI6MTcwNjUyNDIzOCwicGF0aCI6Ii85ODgxMjYyLzMwMDM5NTE4MS04MTU4Yjk3OC05ZTEwLTRjYzEtYTQ2Zi1hNTQ4YTNhOWQ1MGIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDEyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAxMjlUMTAzMDM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWIzMjExMGVmMTcyOWY5ZjNlYThjYjMzYzE5YTEwM2I5YWJkMDY0NDhiZTg0ODJjOGMzMGUzNTgzN2YzNzZiZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.1X2fImjGeGGptrot9q7IEyU_EfvjywinQkg-qvglY_U"><br/><img src="https://private-user-images.githubusercontent.com/9881262/300406093-f287a369-f4aa-47f5-a387-cbf50c8e9c55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.ey
 Jpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY1MjQ1MzgsIm5iZiI6MTcwNjUyNDIzOCwicGF0aCI6Ii85ODgxMjYyLzMwMDQwNjA5My1mMjg3YTM2OS1mNGFhLTQ3ZjUtYTM4Ny1jYmY1MGM4ZTljNTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDEyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAxMjlUMTAzMDM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWIyY2Q5ZDE3N2RkNDI1YTQ0MDE0MzJlZjk1MTdkYzI2ZDlmNzhhOTlkY2U5OWUwOTdlMjAxNWVhNTUyZTdhNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.CQGiipHEl5i_5xdeUf29Ez3aM04RI23oX8w50fI9vXU">
   
   ### AFTERSCREENSHOTS
   /home/david/geodata-env/france_regions_geojson.png
   
   ### ADDITIONAL INFORMATION
   - [x ] Has associated issue: #26846
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): Simplify and reproject France Regions map [superset]

Posted by "dmeaux (via GitHub)" <gi...@apache.org>.
dmeaux closed pull request #26848: fix(dashboard): Simplify and reproject France Regions map
URL: https://github.com/apache/superset/pull/26848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): Simplify and reproject France Regions map [superset]

Posted by "qleroy (via GitHub)" <gi...@apache.org>.
qleroy commented on PR #26848:
URL: https://github.com/apache/superset/pull/26848#issuecomment-1914504394

   I confirm that the new geojson file gets displayed correctly in the graph preview !
   Thank you for the fix
   It is very much appreciated.
   
   <img width="1367" alt="Screenshot 2024-01-29 at 12 31 17" src="https://github.com/apache/superset/assets/9881262/dd75f00d-293b-4183-a29f-3f2cb0c882b2">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): Simplify and reproject France Regions map [superset]

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley closed pull request #26848: fix(dashboard): Simplify and reproject France Regions map
URL: https://github.com/apache/superset/pull/26848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): Simplify and reproject France Regions map [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #26848:
URL: https://github.com/apache/superset/pull/26848#issuecomment-1917553387

   It seems like we have conflicts that need to be resolved, but I'd love to get this merged. Also, do you know how to add/support this in the python notebook? I have a PR open to consolidate everything into that workflow, but right now the Italy Regions and France Regions maps are the exceptions I still want to sort out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org