Re: [IMP] building Xalan (was: DO NOT REPLY [Bug 28032])

[Joerg Heinicke <jo...@gmx.de>]

Antonio Gallardo <agallardo <at> agssa.net> writes:

> Looking inside the current xalan.jar in the CVS there is still the code of
> jakarta-regexp: http://jakarta.apache.org/regexp/index.html

Yes, Stephan only has removed BCEL stuff from it. Therefore I recommended to use
target "unbundledjar" as this builds a clean jar. Unfortunately this breaks
XSLTC as Java CUP Runtime classes are missing. Now we can add this JAR
(http://www.cs.princeton.edu/~appel/modern/java/CUP) ourselves or modify the
Xalan build system locally: There is a target "xsltc.copy-deps-jars" where I
uncommented the antcall to target "xsltc.copy-deps-jar" for bcel and regexp.
This jar is now working for me. I will commit it.

Joerg

Re: [IMP] building Xalan (was: DO NOT REPLY [Bug 28032])

[Joerg Heinicke <jo...@gmx.de>]

Antonio Gallardo <agallardo <at> agssa.net> writes:

> I think there can be far more posible combinations since there are more
> than 2 version for each jar. But this is OT.

*argh* But not at build time of Xalan jar. There you have 3 jars, exactly one
version of each and you can either include or exclude each of them. So please
don't make me angry ;-)

> > Therefore I only asked for
> >
> > - either "build unbundledjar" + adding java-cup.jar to our CVS
> 
> -1 As you posted it encrease the complexity without any valid reason.

I thought that this version is even less "complex" for the committer and should
not be of interest for the user.

> > - or "build jar" + removing the bcel and regexp stuff out of it (pre:
> > modify
> > build.xml, post: remove bcel/regexp by hand after the jar has been
> > created)
> 
> This is good, because we uses the Apache jars in other blocks (not only in
> xalan) and by unbundled it from xalan we can choose the version we need.

I don't know if you got the point: bcel and regexp are neither included in the
above solution, so at the end the xalan.jar is the same. The question is only
about how to get this jar. And therefore the first way including java-cup.jar in
our CVS and generate the clean xalan jar seems to be the better (because
simpler) variant to me.

> BTW, inside the last posted xalan.jar there are still 4 files:
> 
> BCEL.README, BCEL.LICENSE, regexp.README and regexp.LICENSE.
> 
> Also inside the META-INF/MANIFEST.MF there is the info about this 2
> removed Apache libs too. IMHO this is not too important, but will be fine
> to end the job. 

Hmm, yes, another negative effect of doing this by hand and an argument for
solution 1.

Joerg

Re: [IMP] building Xalan (was: DO NOT REPLY [Bug 28032])

[Antonio Gallardo <ag...@agssa.net>]

Joerg Heinicke dijo:
> Antonio Gallardo <agallardo <at> agssa.net> writes:
>
>> > Therefore I recommended to use target "unbundledjar" as this builds a
>> clean
>> > jar. Unfortunately this breaks XSLTC as Java CUP Runtime classes are
>> missing.
>> > Now we can add this JAR
>> (http://www.cs.princeton.edu/~appel/modern/java/CUP)
>> > ourselves or modify the Xalan build system locally: There is a target
>> > "xsltc.copy-deps-jars" where I uncommented the antcall to target
>> > "xsltc.copy-deps-jar" for bcel and regexp.
>> > This jar is now working for me. I will commit it.
>>
>> Great work! I think we can request a new target: "unbundled just Apache
>> libs" to the Xalan project.
>>
>> WDYT?
>
> I would not like it as part of Xalan community. At the moment there are 3
> jars
> to be included or not. At the end you can provide 2^3=8 targets for all
> different combinations of include the one or the other or not. IMO that's
> overcharged.

I think there can be far more posible combinations since there are more
than 2 version for each jar. But this is OT.

> Therefore I only asked for
>
> - either "build unbundledjar" + adding java-cup.jar to our CVS

-1 As you posted it encrease the complexity without any valid reason.

> - or "build jar" + removing the bcel and regexp stuff out of it (pre:
> modify
> build.xml, post: remove bcel/regexp by hand after the jar has been
> created)

This is good, because we uses the Apache jars in other blocks (not only in
xalan) and by unbundled it from xalan we can choose the version we need.

BTW, inside the last posted xalan.jar there are still 4 files:

BCEL.README, BCEL.LICENSE, regexp.README and regexp.LICENSE.

Also inside the META-INF/MANIFEST.MF there is the info about this 2
removed Apache libs too. IMHO this is not too important, but will be fine
to end the job. ;-)

WDYT?

Best Regards,

Antonio Gallardo

Re: [IMP] building Xalan (was: DO NOT REPLY [Bug 28032])

[Joerg Heinicke <jo...@gmx.de>]

Antonio Gallardo <agallardo <at> agssa.net> writes:

> > Therefore I recommended to use target "unbundledjar" as this builds a clean
> > jar. Unfortunately this breaks XSLTC as Java CUP Runtime classes are missing.
> > Now we can add this JAR (http://www.cs.princeton.edu/~appel/modern/java/CUP)
> > ourselves or modify the Xalan build system locally: There is a target
> > "xsltc.copy-deps-jars" where I uncommented the antcall to target
> > "xsltc.copy-deps-jar" for bcel and regexp.
> > This jar is now working for me. I will commit it.
> 
> Great work! I think we can request a new target: "unbundled just Apache
> libs" to the Xalan project.
> 
> WDYT?

I would not like it as part of Xalan community. At the moment there are 3 jars
to be included or not. At the end you can provide 2^3=8 targets for all
different combinations of include the one or the other or not. IMO that's
overcharged.

Therefore I only asked for

- either "build unbundledjar" + adding java-cup.jar to our CVS

- or "build jar" + removing the bcel and regexp stuff out of it (pre: modify
build.xml, post: remove bcel/regexp by hand after the jar has been created)

Joerg

Re: [IMP] building Xalan (was: DO NOT REPLY [Bug 28032])

[Antonio Gallardo <ag...@agssa.net>]

Hi Joerg:

First of all, many thanks for the work!

Joerg Heinicke dijo:
> Antonio Gallardo <agallardo <at> agssa.net> writes:
>
>> Looking inside the current xalan.jar in the CVS there is still the code
>> of
>> jakarta-regexp: http://jakarta.apache.org/regexp/index.html
>
> Yes, Stephan only has removed BCEL stuff from it. Therefore I recommended
> to use
> target "unbundledjar" as this builds a clean jar. Unfortunately this
> breaks
> XSLTC as Java CUP Runtime classes are missing. Now we can add this JAR
> (http://www.cs.princeton.edu/~appel/modern/java/CUP) ourselves or modify
> the
> Xalan build system locally: There is a target "xsltc.copy-deps-jars" where
> I
> uncommented the antcall to target "xsltc.copy-deps-jar" for bcel and
> regexp.
> This jar is now working for me. I will commit it.

Great work! I think we can request a new target: "unbundled just Apache
libs" to the Xalan project.

WDYT?

Best Regards,

Antonio Gallardo