You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "JHoelli (via GitHub)" <gi...@apache.org> on 2026/08/14 11:09:50 UTC
[PR] 4734 align backend internal dataset terminology
JHoelli opened a new pull request, #4833:
URL: https://github.com/apache/streampipes/pull/4833
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/community/get-involved/
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): <yes/no>
PR introduces (a) deprecation(s): <yes/no>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 4734 align backend internal dataset terminology
Posted by "JHoelli (via GitHub)" <gi...@apache.org>.
JHoelli commented on PR #4833:
URL: https://github.com/apache/streampipes/pull/4833#issuecomment-5731258171
- [ ] MigrateDataLakeDatabaseToDatasetMigration loads all documents into a single array. There is a high chance that this HTTP request fails due to high response times or document size. It's probably better to migrate one-by-one (with checkpoints) or to leave the database name as is.
- [X] Why does the DataLakeSink have a new version (3) even though there is no migration?
--> Legacy change. In a first version we migrated the data sink via data sink migration. Due to the highly intertwined data sink, the migration is now moved to the Core, to be able to also migrate all other related documents !
- [X]DataLakeMeasure is marked as deprecated but moved into a new package, so this is more a breaking change than a deprecation -> we should decide if we completely replace it or leave the deprecated class in the same package
--> Added path to deprecation, only for dataLake Measure as this is the only part the deprecated client api relies on.
- [X] Since we don't migrate the models in the UI, the backend code and typescript code can diverge (e.g. a wrong class name is assigned to the DataLakeMeasure in streampipes-model.ts, which becomes a DatasetMetadata class later in streampipes-rest. Does this cause any problems?
--> now migrated, was working due to the deprecation of DataLakeMeasure, would break as soon as deprecated class is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 4734 align backend internal dataset terminology
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on PR #4833:
URL: https://github.com/apache/streampipes/pull/4833#issuecomment-5713800495
I have a few comments we need to address before merging:
* MigrateDataLakeDatabaseToDatasetMigration loads all documents into a single array. There is a high chance that this HTTP request fails due to high response times or document size. It's probably better to migrate one-by-one or to leave the database name as is.
* Why does the DataLakeSink have a new version (3) even though there is no migration?
* `DataLakeMeasure` is marked as deprecated but moved into a new package, so this is more a breaking change than a deprecation -> we should decide if we completely replace it or leave the deprecated class in the same package
* Since we don't migrate the models in the UI, the backend code and typescript code can diverge (e.g. a wrong class name is assigned to the `DataLakeMeasure` in `streampipes-model.ts`, which becomes a `DatasetMetadata` class later in `streampipes-rest`. Does this cause any problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(#4734): Align backend internal dataset terminology
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #4833:
URL: https://github.com/apache/streampipes/pull/4833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org