You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2023/09/26 13:48:40 UTC

[GitHub] [yunikorn-site] rich7420 opened a new pull request, #343: [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking

rich7420 opened a new pull request, #343:
URL: https://github.com/apache/yunikorn-site/pull/343

   ### What is this PR for?
   
   The Chinese translation for the document Adding Chinese translation of User Based Resource Usage Tracking
   in  current design/user_based_resource_usage_tracking
   
   ### What type of PR is it?
   
   - [x]  Improvement
   - [x]  Documentation
   
   ### What is the Jira issue?
   
   [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking
   
   - https://issues.apache.org/jira/browse/YUNIKORN-1692
   
   ### How should this be tested?
   
   ./local_build run (make sure all related json files are created in .docusaurus)
   ./local_build run zh-cn (This step will create additional translated json files in .docusaurus)
   
   ### Screenshots (if appropriate)
   ![image](https://github.com/apache/yunikorn-site/assets/101171023/6e07f882-72ee-42b5-9024-95ffa39661e7)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking [yunikorn-site]

Posted by "wusamzong (via GitHub)" <gi...@apache.org>.
wusamzong commented on code in PR #343:
URL: https://github.com/apache/yunikorn-site/pull/343#discussion_r1342482271


##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/workloads/run_nvidia.md:
##########
@@ -0,0 +1,347 @@
+---

Review Comment:
   A branch should only resolve a single Issue to prevent the content of different issues from being included in the same PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking [yunikorn-site]

Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #343:
URL: https://github.com/apache/yunikorn-site/pull/343#issuecomment-1958406554

   No longer relevant after [YUNIKORN-2411](https://issues.apache.org/jira/browse/YUNIKORN-2411)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking [yunikorn-site]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #343:
URL: https://github.com/apache/yunikorn-site/pull/343#discussion_r1348346859


##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/workloads/run_nvidia.md:
##########
@@ -0,0 +1,347 @@
+---

Review Comment:
   OKay, thanks for your advice. I changed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking [yunikorn-site]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #343:
URL: https://github.com/apache/yunikorn-site/pull/343#discussion_r1348346859


##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/user_guide/workloads/run_nvidia.md:
##########
@@ -0,0 +1,347 @@
+---

Review Comment:
   OK, thanks for your advice. I changed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking [yunikorn-site]

Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #343: [Yunikorn 1692] Adding Chinese translation of User Based Resource Usage Tracking
URL: https://github.com/apache/yunikorn-site/pull/343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org